filter_aws: add more IMDS categories#9727
Open
commiterate wants to merge 1 commit into
Open
Conversation
4d665f4 to
b51d689
Compare
Signed-off-by: commiterate <111539270+commiterate@users.noreply.github.com>
b51d689 to
398a519
Compare
Member
Author
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Author
|
@sparrc @singholt @swapneils Does one of you have bandwidth to review this? |
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Author
|
@patrick-stephens Could you add the |
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
|
hmm stale bot ignored me lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more IMDS categories.
Excluding the EC2 Auto Scaling target lifecycle state (
autoscaling/target-lifecycle-state) from the feature request since the AWS filter seems to assume that IMDS data is immutable. We can just make the process that polls it log the state to stdout (for systemd-journald) or syslog to correlate on-system events.Note that dedicated host ID (and other metadata, both existing and new) may also be mutable due to live migration.
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/dedicated-hosts-maintenance-basics.html
Fixes #9640.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1530
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.