Skip to content

filter_aws: add more IMDS categories#1530

Open
commiterate wants to merge 3 commits into
fluent:masterfrom
commiterate:add_more_imds_categories
Open

filter_aws: add more IMDS categories#1530
commiterate wants to merge 3 commits into
fluent:masterfrom
commiterate:add_more_imds_categories

Conversation

@commiterate
Copy link
Copy Markdown

@commiterate commiterate commented Dec 16, 2024

Add more IMDS categories.

Relates to fluent/fluent-bit#9640.

Requires fluent/fluent-bit#9727 to be merged.

Summary by CodeRabbit

  • Documentation
    • Updated AWS metadata filter documentation with expanded configuration options, including new parameters for placement groups, domain settings, IPv6 support, and host identifiers, along with improved configuration examples.

Review Change Stack

@commiterate commiterate requested review from a team as code owners December 16, 2024 00:03
@commiterate commiterate force-pushed the add_more_imds_categories branch 2 times, most recently from e65b240 to ba4e7b7 Compare December 16, 2024 03:06
Copy link
Copy Markdown
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @commiterate! I suggested some editorial changes from a technical writing perspective.

Comment thread pipeline/filters/aws-metadata.md Outdated
Comment thread pipeline/filters/aws-metadata.md Outdated
Comment thread pipeline/filters/aws-metadata.md Outdated
Comment thread pipeline/filters/aws-metadata.md Outdated
Comment thread pipeline/filters/aws-metadata.md Outdated
@commiterate commiterate force-pushed the add_more_imds_categories branch from ba4e7b7 to e3d59fd Compare December 20, 2024 19:02
@eschabell eschabell added the conflict Waiting on conflict to be resolved by contributor label Oct 22, 2025
@eschabell eschabell self-assigned this Oct 22, 2025
@eschabell eschabell added the waiting-for-user Waiting for user/contributors feedback or requested changes label Oct 22, 2025
@eschabell
Copy link
Copy Markdown
Collaborator

@commiterate can you resolve the conflict?

Signed-off-by: commiterate <111539270+commiterate@users.noreply.github.com>
@commiterate commiterate force-pushed the add_more_imds_categories branch from e3d59fd to 0cf8158 Compare October 22, 2025 01:57
@commiterate
Copy link
Copy Markdown
Author

@eschabell Done.

@patrick-stephens patrick-stephens removed waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor labels Nov 5, 2025
@eschabell eschabell added 4.2.1 and removed 4.2.1 labels Dec 3, 2025
Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-requested a review as a code owner May 27, 2026 14:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Warning

Review limit reached

@eschabell, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 49 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ffdf1931-de02-44b4-b032-7d73480021a2

📥 Commits

Reviewing files that changed from the base of the PR and between b7f6cb8 and 592a577.

📒 Files selected for processing (1)
  • pipeline/filters/aws-metadata.md
📝 Walkthrough

Walkthrough

The AWS metadata filter documentation was updated to expand the parameter reference table with newly supported configuration options (az_id, domain, host_id, ipv6, placement_group, partition_number, public_ip) and revise configuration examples to demonstrate more comprehensive filter usage patterns with updated formatting.

Changes

AWS Metadata Filter Documentation

Layer / File(s) Summary
Parameter reference table expansion
pipeline/filters/aws-metadata.md
The parameters table documents new AWS metadata filter options including availability zone ID, domain, dedicated host ID, and network/placement-related fields.
Configuration examples and usage
pipeline/filters/aws-metadata.md
The fluent-bit.conf example expands to show comprehensive AWS filter directives, and the tags_include example is updated to align with the revised formatting structure.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 The AWS docs now shine so bright,
With metadata fields added just right,
Examples expanded from old to new,
A filter guide fresh and true! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'filter_aws: add more IMDS categories' clearly summarizes the main change - adding additional IMDS (Instance Metadata Service) categories to the AWS metadata filter documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell
Copy link
Copy Markdown
Collaborator

Fixed conflicts for you @commiterate

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

♻️ Duplicate comments (1)
pipeline/filters/aws-metadata.md (1)

154-154: ⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Fix missing closing quote in YAML.

The match parameter is missing a closing single quote, which would cause YAML parsing errors.

🐛 Proposed fix to add closing quote
-      match: '*
+      match: '*'
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pipeline/filters/aws-metadata.md` at line 154, The YAML `match` parameter is
missing its closing single quote; update the `match` entry (the line containing
match) to include the closing quote so it reads match: '*' (or use double quotes
like match: "*") to fix the YAML parsing error.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pipeline/filters/aws-metadata.md`:
- Line 115: Remove the trailing whitespace after the value on the "Public_Ip    
true" line in pipeline/filters/aws-metadata.md so the line ends immediately
after "true"; locate the "Public_Ip" entry and trim any extra spaces or tabs
following the boolean literal to avoid trailing whitespace.
- Around line 106-112: Remove the duplicated configuration entries for
Ec2_Instance_Id and Ec2_Instance_Type that were accidentally repeated; locate
the second occurrences of the symbols "Ec2_Instance_Id" and "Ec2_Instance_Type"
in the aws metadata filter block and delete those duplicate lines so each key
appears only once, then scan the block to ensure there are no other accidental
duplicates.

---

Duplicate comments:
In `@pipeline/filters/aws-metadata.md`:
- Line 154: The YAML `match` parameter is missing its closing single quote;
update the `match` entry (the line containing match) to include the closing
quote so it reads match: '*' (or use double quotes like match: "*") to fix the
YAML parsing error.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5ed2846e-46ae-4a46-8f00-6a069075f465

📥 Commits

Reviewing files that changed from the base of the PR and between 5231934 and b7f6cb8.

📒 Files selected for processing (1)
  • pipeline/filters/aws-metadata.md

Comment thread pipeline/filters/aws-metadata.md Outdated
Comment thread pipeline/filters/aws-metadata.md Outdated
…space

  - Remove duplicate Ec2_Instance_Id and Ec2_Instance_Type lines in classic config example
  - Remove trailing whitespace after Public_Ip value

  Applies to fluent#1530.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
Copy link
Copy Markdown
Collaborator

@eschabell eschabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commiterate just waiting on code PR merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants