filter_aws: add more IMDS categories#1530
Conversation
e65b240 to
ba4e7b7
Compare
lockewritesdocs
left a comment
There was a problem hiding this comment.
Thanks for your contribution @commiterate! I suggested some editorial changes from a technical writing perspective.
ba4e7b7 to
e3d59fd
Compare
|
@commiterate can you resolve the conflict? |
Signed-off-by: commiterate <111539270+commiterate@users.noreply.github.com>
e3d59fd to
0cf8158
Compare
|
@eschabell Done. |
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
Warning Review limit reached
More reviews will be available in 15 minutes and 49 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe AWS metadata filter documentation was updated to expand the parameter reference table with newly supported configuration options ( ChangesAWS Metadata Filter Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fixed conflicts for you @commiterate |
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
pipeline/filters/aws-metadata.md (1)
154-154:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winFix missing closing quote in YAML.
The
matchparameter is missing a closing single quote, which would cause YAML parsing errors.🐛 Proposed fix to add closing quote
- match: '* + match: '*'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pipeline/filters/aws-metadata.md` at line 154, The YAML `match` parameter is missing its closing single quote; update the `match` entry (the line containing match) to include the closing quote so it reads match: '*' (or use double quotes like match: "*") to fix the YAML parsing error.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/filters/aws-metadata.md`:
- Line 115: Remove the trailing whitespace after the value on the "Public_Ip
true" line in pipeline/filters/aws-metadata.md so the line ends immediately
after "true"; locate the "Public_Ip" entry and trim any extra spaces or tabs
following the boolean literal to avoid trailing whitespace.
- Around line 106-112: Remove the duplicated configuration entries for
Ec2_Instance_Id and Ec2_Instance_Type that were accidentally repeated; locate
the second occurrences of the symbols "Ec2_Instance_Id" and "Ec2_Instance_Type"
in the aws metadata filter block and delete those duplicate lines so each key
appears only once, then scan the block to ensure there are no other accidental
duplicates.
---
Duplicate comments:
In `@pipeline/filters/aws-metadata.md`:
- Line 154: The YAML `match` parameter is missing its closing single quote;
update the `match` entry (the line containing match) to include the closing
quote so it reads match: '*' (or use double quotes like match: "*") to fix the
YAML parsing error.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5ed2846e-46ae-4a46-8f00-6a069075f465
📒 Files selected for processing (1)
pipeline/filters/aws-metadata.md
…space - Remove duplicate Ec2_Instance_Id and Ec2_Instance_Type lines in classic config example - Remove trailing whitespace after Public_Ip value Applies to fluent#1530. Signed-off-by: Eric D. Schabell <eric@schabell.org>
eschabell
left a comment
There was a problem hiding this comment.
@commiterate just waiting on code PR merging.
Add more IMDS categories.
Relates to fluent/fluent-bit#9640.
Requires fluent/fluent-bit#9727 to be merged.
Summary by CodeRabbit