Cleanup the profile info panel for size profiles #5657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5657 +/- ##
==========================================
- Coverage 85.63% 85.58% -0.06%
==========================================
Files 312 312
Lines 30867 30918 +51
Branches 8488 8532 +44
==========================================
+ Hits 26434 26462 +28
- Misses 4009 4026 +17
- Partials 424 430 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
mstange
requested changes
Nov 6, 2025
Comment on lines
261
to
268
| {meta.endTime && meta.startTime !== undefined ? ( | ||
| <div className="metaInfoRow"> | ||
| <span className="metaInfoLabel"> | ||
| <Localized id="MenuButtons--metaInfo--file-size"> | ||
| File size: | ||
| </Localized> | ||
| </span> | ||
| {formatBytes(meta.endTime - meta.startTime)} |
Contributor
There was a problem hiding this comment.
I think I'd prefer a separate fileSize property over this. Yes it's somewhat consistent but it's also quite strange to read.
Comment on lines
251
to
259
| {meta.fileName ? ( | ||
| <div className="metaInfoRow"> | ||
| <span className="metaInfoLabel"> | ||
| <Localized id="MenuButtons--metaInfo--file-name"> | ||
| File name: | ||
| </Localized> | ||
| </span> | ||
| {meta.fileName} | ||
| </div> |
Contributor
There was a problem hiding this comment.
How would you feel about showing File name for all types of profiles, if the property is present?
Comment on lines
354
to
360
| {meta.product || | ||
| meta.profilingStartTime || | ||
| meta.updateChannel || | ||
| meta.appBuildID || | ||
| meta.debug !== undefined || | ||
| meta.extensions || | ||
| meta.arguments ? ( |
Contributor
There was a problem hiding this comment.
This is a long check, same with the "shouldShowPlatformSection" check below. Please break up this function into multiple this._renderXYZ() functions, one per section. Then we can have this check as an early return.
flodolo
approved these changes
Nov 6, 2025
…name, hide empty sections).
fqueze
force-pushed
the
size-profile-info
branch
from
0f0b78b to
c642a4d
Compare
Merged
canova
added a commit
that referenced
this pull request
Nov 12, 2025
Changes: [Nazım Can Altınova] Use getEmptySourceTable instead of constructing the table manually (#5641) [Florian Quèze] Source view for marker stacks (#5633) [Nazım Can Altınova] Add fallback to funcTable.lineNumber when computing line timings (#5644) [Florian Quèze] Show the marker keys instead of the labels in marker tooltips when alt is pressed. (#5625) [Francesco Lodolo] Add GitHub workflow to check Fluent reference files (#5647) [Nazım Can Altınova] Switch from Gitpod to GitHub Codespaces (#5653) [Nazım Can Altınova] Migrate from CircleCI to GitHub Actions (#5654) [Nazım Can Altınova] Run the CI in the production branch and on every pull request (#5661) [Nazım Can Altınova] Convert l10n-sync.js from Flow comment types to JSDoc comments for Typescript (#5659) [Florian Quèze] Display correct unit in Stack Chart tooltips for size profiles. (#5658) [Florian Quèze] Hide track management UI in single track profiles. (#5656) [Florian Quèze] Rename hiddenTrackCount to trackCount. (#5665) [Florian Quèze] Cleanup the profile info panel for size profiles (show file size and name, hide empty sections). (#5657) [Markus Stange] Use valibot for symbolication API response validation (#5666) [Nazım Can Altınova] Make sure to fetch the full git history for l10n-sync job in CI (#5667) [Nazım Can Altınova] Do not switch to call tree when clicking the activity graph while on sample based panels (#5672) And thanks to our localizers: be: Mikalai Udodau de: Michael Köhler el: Jim Spentzos en-GB: Ian Neal es-CL: ravmn fr: Théo Chevalier fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: berry, Valery Ledovskoy sv-SE: Andreas Pettersson tr: Grk zh-CN: Olvcpr423, wxie zh-TW: Pin-guang Chen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example profile with the fileName field: https://share.firefox.dev/4qL68wH
Deploy preview: https://deploy-preview-5657--perf-html.netlify.app/public/1hf6rzbjx1dspn1v4eqcgnybtzzczf2f889ce10/stack-chart/