Skip to content

Migrate Home page animation to CSS transitions and remove react-transition-group #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mstange wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Migrate Home page animation to CSS transitions and remove react-transition-group #5649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f81bee9
Use CSS transitions for the Home page animations.
mstange Aug 31, 2025
b91bec5
Remove react-transition-group dependency.
mstange Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"react-intersection-observer": "^9.16.0",
"react-redux": "^9.2.0",
"react-splitter-layout": "^4.0.0",
"react-transition-group": "^4.4.5",
"redux": "^5.0.1",
"redux-logger": "^3.0.6",
"redux-thunk": "^3.1.0",
Expand Down Expand Up @@ -127,7 +126,6 @@
"@types/react": "^18.3.26",
"@types/react-dom": "^18.3.1",
"@types/react-splitter-layout": "^4.0.0",
"@types/react-transition-group": "^4.4.5",
"@types/redux-logger": "^3.0.6",
"@types/tgwf__co2": "^0.14.2",
"@typescript-eslint/eslint-plugin": "^8.45.0",
Expand Down
9 changes: 7 additions & 2 deletions src/components/app/Home.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,18 +172,23 @@

/* Only show the home transition when reduced motion is not preferred */
@media (prefers-reduced-motion: no-preference) {
.homeTransition-enter {
.homeTransition-preEnter {
opacity: 0.1;
transform: translateX(100px);
}

.homeTransition-enter.homeTransition-enter-active {
.homeTransition-entering {
opacity: 1;
transform: translateX(0);
transition:
opacity 300ms ease-out,
transform 300ms ease-out;
}

.homeTransition-entered {
opacity: 1;
transform: translateX(0);
}
}

.homeSectionUploadFromFileInput {
Expand Down
16 changes: 4 additions & 12 deletions src/components/app/Home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
triggerLoadingFromUrl,
} from 'firefox-profiler/actions/receive-profile';
import type { BrowserConnection } from 'firefox-profiler/app-logic/browser-connection';
import { CSSTransition, TransitionGroup } from 'react-transition-group';
import {
queryIsMenuButtonEnabled,
enableMenuButton,
Expand Down Expand Up @@ -182,15 +181,8 @@ function DocsButton() {
);
}

function InstructionTransition(props: { children: React.ReactNode }) {
return (
<CSSTransition
{...props}
classNames="homeTransition"
timeout={300}
exit={false}
/>
);
function InstructionTransition({ children }: { children: React.ReactNode }) {
return <div className="homeTransition-entered">{children}</div>;
}

type OwnHomeProps = {
Expand Down Expand Up @@ -590,9 +582,9 @@ class HomeImpl extends React.PureComponent<HomeProps, HomeState> {
faster.
</p>
</Localized>
<TransitionGroup className="homeInstructionsTransitionGroup">
<div className="homeInstructionsTransitionGroup">
{this._renderInstructions()}
</TransitionGroup>
</div>
<section className="homeAdditionalContent">
{/* Grid container: homeAdditionalContent */}
<h2 className="homeAdditionalContentTitle protocol-display-xs">
Expand Down
Loading