chore(genkit-tools): update model and middleware types by MichaelDoyle · Pull Request #4785 · firebase/genkit

MichaelDoyle · 2026-02-20T03:59:42Z

I'm "pulling forward" the middleware schema, so to speak
Updated a couple small things missing in js/ai/src/model.ts and js/ai/src/parts.ts as well.

gemini-code-assist · 2026-02-20T04:00:06Z

Summary of Changes

Hello @MichaelDoyle, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining and expanding the type definitions within the genkit-tools project, particularly for models and middleware. The changes aim to provide more robust and descriptive schemas for various components, enhance configuration options for generation requests, and ensure the JSON schema accurately reflects these updated types. This improves clarity, maintainability, and consistency across the codebase.

Highlights

Middleware Type Definition: Introduced a new MiddlewareDescSchema and MiddlewareDesc type to define the structure for registered middleware, including its name, description, configuration schema, and metadata.
Model and Part Type Refinements: Re-organized and refined PartSchema definitions across model.ts and parts.ts. The comprehensive PartSchema (union of all part types) is now defined in model.ts, while parts.ts provides a simplified PartSchema for text and media, along with specific type exports.
Enhanced Generation Configuration: Updated GenerationCommonConfigSchema with more detailed descriptions for existing properties, added an apiKey field, and changed its behavior to allow additional properties (passthrough).
New Model Reference Schema: Added ModelReferenceSchema to define the structure for referencing models, including their name, configuration schema, info, version, and specific configuration.
JSON Schema Synchronization: Synchronized genkit-schema.json to reflect all type definition changes, including the new MiddlewareDesc and ModelReference schemas, updated GenerationCommonConfig properties, and explicit listing of all part types within MessageSchema content.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

genkit-tools/common/src/types/common.ts
- Added MiddlewareDescSchema and MiddlewareDesc for defining middleware descriptors.
genkit-tools/common/src/types/index.ts
- Exported new common types, including middleware descriptors.
genkit-tools/common/src/types/model.ts
- Removed redundant PartSchema imports/exports.
- Introduced ModelReferenceSchema for model references.
- Re-defined PartSchema to include all specific part types (Text, Media, ToolRequest, ToolResponse, Data, Custom, Reasoning, Resource).
- Removed longRunning property from ModelInfoSchema.
- Enhanced GenerationCommonConfigSchema with detailed descriptions, an apiKey field, and passthrough behavior.
- Added resources field to GenerateActionOptionsSchema.
genkit-tools/common/src/types/parts.ts
- Added TextPart and ToolRequest type exports.
- Updated description for TextPartSchema from 'document' to 'message'.
- Added JSDoc comments for ToolResponseSchema and ToolResponsePart.
- Simplified PartSchema to only union TextPartSchema and MediaPartSchema.
genkit-tools/genkit-schema.json
- Added resources field to GenerateActionOptions.
- Expanded MessageSchema content items to explicitly list all part types using anyOf.
- Enhanced GenerationCommonConfigSchema with detailed descriptions, an apiKey field, and allowed additional properties.
- Removed longRunning from ModelInfoSchema.
- Added ModelReference schema.
- Simplified the top-level Part schema definition.
js/ai/src/model.ts
- Imported and re-exported additional part schemas and types, including MultipartToolResponse, ReasoningPart, and ResourcePart.
js/ai/src/parts.ts
- Added TextPart and ReasoningPart type exports.
- Updated description for TextPart.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request updates model and middleware types, and introduces a new common.ts file for MiddlewareDescSchema. It also refactors PartSchema in model.ts and parts.ts to improve clarity and consistency. Additionally, ModelReferenceSchema is added, and GenerationCommonConfigSchema is enhanced with descriptions and an apiKey field. The genkit-schema.json file is updated to reflect these changes, including the addition of resources to GenerateActionOptions and a more detailed content definition for GenerateResponseChunk.

genkit-tools/common/src/types/model.ts

genkit-tools/genkit-schema.json

MichaelDoyle · 2026-02-20T04:09:36Z

@huangjeff5 what do we need to do about the python errors? I don't think this should necessarily be causing an error. Either there is a problem in the translation step, or the rule needs to be relaxed?

genkit-tools/common/src/types/common.ts

genkit-tools/common/src/types/model.ts

huangjeff5 · 2026-02-20T18:14:20Z

@huangjeff5 what do we need to do about the python errors? I don't think this should necessarily be causing an error. Either there is a problem in the translation step, or the rule needs to be relaxed?

Looking

pavelgj · 2026-02-20T22:24:46Z

genkit-tools/common/src/types/parts.ts

 */
 export type ToolResponse = z.infer<typeof ToolResponseSchemaBase> & {
-  content?: Part[];
+  content?: DocumentPart[];


why this change?

There is a collision with multiple definitions of Part (models.ts, parts.ts) as both get exported, which causes an issue for the JSON schema generation.

Previously this was isolated to documents.ts, but after things got refactored out into parts.ts it became a broader issue.

This means we are downgrading from a generic part to only text/media parts, it this intentional?

Not quite. Both Document (via document.ts) and Tools (via parts.ts) have Part as defined TextPart | MediaPart. This was my/gemini's attempt to consolidate the two.

Probably it will be least confusing to just let each file redefine Part as it was doing before, but give them a different name in each place?

The issue we have is we do export * filename for every files types. So we have 3 definitions of Part. document.ts, model.ts and parts.ts, which will not work.

See also: https://github.com/firebase/genkit/blob/main/js/ai/src/parts.ts#L179-L185

ssbushi · 2026-02-23T15:54:08Z

genkit-tools/common/src/types/parts.ts

 export const MultipartToolResponseSchema = z.object({
  output: z.unknown().optional(),
-  content: z.array(PartSchema).optional(),
+  content: z.array(DocumentPartSchema).optional(),


See also: https://github.com/firebase/genkit/blob/main/js/ai/src/parts.ts#L179-L185

MichaelDoyle · 2026-02-24T22:51:31Z

I broke this out into 3 PRs to make it easier to review and merge, since I touched things from 3 different areas.

MichaelDoyle requested review from ifielker, pavelgj and ssbushi as code owners February 20, 2026 03:59

github-project-automation bot added this to Genkit Backlog Feb 20, 2026

github-actions bot added js tooling labels Feb 20, 2026

gemini-code-assist bot reviewed Feb 20, 2026

View reviewed changes

MichaelDoyle force-pushed the update-tools branch 2 times, most recently from 99442ef to 60dc9a6 Compare February 20, 2026 14:33

ssbushi reviewed Feb 20, 2026

View reviewed changes

genkit-tools/common/src/types/common.ts Outdated Show resolved Hide resolved

genkit-tools/common/src/types/common.ts Outdated Show resolved Hide resolved

genkit-tools/common/src/types/model.ts Outdated Show resolved Hide resolved

genkit-tools/common/src/types/model.ts Show resolved Hide resolved

MichaelDoyle force-pushed the update-tools branch 5 times, most recently from 42c50d2 to 6b27c03 Compare February 20, 2026 17:35

MichaelDoyle requested a review from ssbushi February 20, 2026 17:41

huangjeff5 mentioned this pull request Feb 20, 2026

chore(py): relax e501 on genkit/core/typing.py #4790

Merged

MichaelDoyle force-pushed the update-tools branch 2 times, most recently from 3d7b8b2 to 3b0adae Compare February 20, 2026 20:45

MichaelDoyle requested a review from huangjeff5 as a code owner February 20, 2026 20:45

github-actions bot added the python Python label Feb 20, 2026

MichaelDoyle force-pushed the update-tools branch 6 times, most recently from c89d0ef to 0295800 Compare February 20, 2026 22:18

MichaelDoyle force-pushed the update-tools branch from 0295800 to 16c120a Compare February 20, 2026 22:19

pavelgj reviewed Feb 20, 2026

View reviewed changes

MichaelDoyle force-pushed the update-tools branch 4 times, most recently from cb7ad0e to 58fa0d5 Compare February 20, 2026 23:01

ssbushi reviewed Feb 23, 2026

View reviewed changes

MichaelDoyle force-pushed the update-tools branch 2 times, most recently from 9d18900 to 67c9dc8 Compare February 24, 2026 22:06

chore(genkit-tools): update model and middleware types

fd50787

MichaelDoyle force-pushed the update-tools branch from 67c9dc8 to fd50787 Compare February 24, 2026 22:11

MichaelDoyle closed this Feb 25, 2026

github-project-automation bot moved this to Done in Genkit Backlog Feb 25, 2026

Conversation

MichaelDoyle commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichaelDoyle commented Feb 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huangjeff5 commented Feb 20, 2026

Uh oh!

pavelgj Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

MichaelDoyle Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ssbushi Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

MichaelDoyle Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MichaelDoyle Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

ssbushi Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

MichaelDoyle Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

MichaelDoyle Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

MichaelDoyle commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MichaelDoyle commented Feb 20, 2026 •

edited

Loading

MichaelDoyle Feb 20, 2026 •

edited

Loading

MichaelDoyle Feb 24, 2026 •

edited

Loading