Skip to content

chore(py): relax e501 on genkit/core/typing.py#4790

Merged
huangjeff5 merged 2 commits intomainfrom
fix-lit
Feb 20, 2026
Merged

chore(py): relax e501 on genkit/core/typing.py#4790
huangjeff5 merged 2 commits intomainfrom
fix-lit

Conversation

@huangjeff5
Copy link
Contributor

Fixes schema changes here: #4785

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @huangjeff5, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the project's linting configuration to relax the line length constraint for a specific Python file. This adjustment aims to address a formatting issue or facilitate schema-related changes, as indicated by the linked PR, by allowing longer lines in the designated file without triggering linting errors.

Highlights

  • Linting Configuration Update: The E501 (line too long) linting rule has been specifically disabled for the packages/genkit/src/genkit/core/typing.py file within the pyproject.toml configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • py/pyproject.toml
    • Added an entry to the [tool.ruff.lint.per-file-ignores] section to ignore the E501 rule for packages/genkit/src/genkit/core/typing.py.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly relaxes the line length requirement (E501) for the auto-generated typing.py file. This is an appropriate change as files generated from schemas often contain long lines that are difficult to wrap without modifying the generator's configuration or templates. The implementation in pyproject.toml is clean and follows the existing project structure, though adding an explanatory comment would improve consistency with other entries in the same section.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@huangjeff5 huangjeff5 enabled auto-merge (squash) February 20, 2026 20:01
@huangjeff5 huangjeff5 merged commit 58b4a82 into main Feb 20, 2026
21 checks passed
@huangjeff5 huangjeff5 deleted the fix-lit branch February 20, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants