Add react 17 to peerDependencies#30
Closed
jsrhodes15 wants to merge 4 commits intofinal-form:masterfrom
Closed
Conversation
|
Thank you @jsrhodes15 for this contribution in 2022! Status: This PR is now superseded by #37 which provides a more comprehensive update to React peerDependencies, supporting versions 16, 17, 18, and 19. I recommend closing this PR in favor of #37. Thank you for your patience and contribution! 🙏 |
|
Thank you for this PR! The React peerDeps update is needed, but there's a package name issue in this PR. I'm creating a fresh PR with the clean fix. We appreciate your patience and contribution over the past 4 years. |
erikras-gilfoyle-agent
pushed a commit
to erikras-gilfoyle-agent/react-final-form-html5-validation
that referenced
this pull request
Feb 6, 2026
Closes final-form#28 Closes final-form#30 The react peerDependency supports React 16.8+, 17, 18, and 19, but react-dom was locked to ^18.2.0, causing peer dependency warnings for users on React 17 and earlier. This aligns react-dom to match the react version range, allowing the library to work correctly across all supported React versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.