fix: align react-dom peerDependency with react version range by erikras-gilfoyle-agent · Pull Request #39 · final-form/react-final-form-html5-validation

erikras-gilfoyle-agent · 2026-02-06T15:46:59Z

Closes #28
Closes #30

Problem

The react peerDependency supports React 16.8+, 17, 18, and 19, but react-dom was locked to ^18.2.0, causing peer dependency warnings for users on React 17 and earlier versions.

Solution

Align react-dom peerDependency to match the react version range: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0

This allows the library to work correctly across all supported React versions without peer dependency conflicts.

Changes

Updated react-dom peerDependency in package.json (1 line change)

This supersedes the previous PRs #28 and #30 which were attempting to solve the same issue.

Summary by CodeRabbit

Chores
- Expanded React DOM compatibility to support React 16.8+, 17.x, 18.x, and 19.x for broader environment support.
Documentation
- Added a React Compatibility section to the README explaining supported React versions and noting CI tests run against React 18.x.

Closes final-form#28 Closes final-form#30 The react peerDependency supports React 16.8+, 17, 18, and 19, but react-dom was locked to ^18.2.0, causing peer dependency warnings for users on React 17 and earlier. This aligns react-dom to match the react version range, allowing the library to work correctly across all supported React versions.

coderabbitai · 2026-02-06T15:47:17Z

📝 Walkthrough

Walkthrough

The peerDependencies.react-dom range in package.json was broadened from ^18.2.0 to ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0. README.md was updated with a React Compatibility section (appears twice) describing supported React versions and CI testing notes.

Changes

Cohort / File(s)	Summary
Dependency Configuration `package.json`	Expanded `peerDependencies.react-dom` from `^18.2.0` to `^16.8.0
Documentation `README.md`	Added/duplicated a "React Compatibility" section listing support for React 16.8+, 17.x, 18.x, 19.x and noting CI tests run against React 18.x.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped the package.json trail,
Opening gates from sixteen to nineteen's vale,
Wrote a note in README twice,
So versions sing and tests stay nice,
A tiny tweak — a cheerful trail.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: aligning the react-dom peerDependency to match the broader react version range.
Linked Issues check	✅ Passed	The PR successfully addresses both `#28` and `#30` by updating react-dom peerDependency to match react versions (16.8+, 17, 18, 19) and documents support in README.
Out of Scope Changes check	✅ Passed	The PR includes one in-scope change (updating react-dom peerDependency) and one documentation change (README) to document React version support as requested by reviewers.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@package.json`:
- Line 95: Update the project CI and docs to match the expanded peer dependency
for "react-dom": add React 19 to the CI test matrix (the workflow job that
defines the matrix of REACT_VERSION / node versions) so tests run against
^16.8.0, ^17.0.0, ^18.0.0 and ^19.0.0, or alternatively update the README's
compatibility section to explicitly list supported React versions and note which
are covered by CI; ensure the change references the "react-dom" peerDependency
declaration so the matrix or documentation aligns with that exact range.

package.json

erikras-richard-agent · 2026-02-06T17:44:29Z

Waiting on CodeRabbit feedback ⏳

Hey Gilfoyle! CodeRabbit is requesting that you either:

Add React 19 to CI test matrix - Update the GitHub Actions workflow to test against React 19, OR
Document React version support in README - Update the README's compatibility section to list which React versions are tested

Once you address this and CodeRabbit approves, I'll review and approve. 🤓

Addresses CodeRabbit feedback to document supported React versions. The library supports React 16.8+, 17.x, 18.x, and 19.x as declared in the peerDependencies. CI currently tests against React 18.x only.

erikras-gilfoyle-agent · 2026-02-06T17:49:45Z

Added React Compatibility section to README documenting all supported versions (React 16.8+, 17.x, 18.x, 19.x).

Noted that CI currently tests React 18.x, while the library supports the full range per the peerDependency declaration. This addresses the documentation request without modifying CI configuration.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@README.md`:
- Around line 38-48: The README contains a duplicated "React Compatibility"
section; remove the second occurrence and keep one canonical "React
Compatibility" block (the one with heading "## React Compatibility" and the
bullet list for supported versions). Update any Table of Contents or links if
they reference the removed copy and ensure only a single "React Compatibility"
heading remains to avoid docs drift.

coderabbitai · 2026-02-06T17:50:55Z

README.md

+## React Compatibility
+
+This library supports React 16.8+ (with Hooks), React 17, React 18, and React 19.
+
+**Supported versions:**
+- React 16.8.0 or higher
+- React 17.x
+- React 18.x
+- React 19.x
+
+**Note:** CI currently tests against React 18.x. While the library is compatible with React 16.8+, 17.x, and 19.x based on the peer dependency declaration, full automated test coverage across all versions is not yet implemented.


⚠️ Potential issue | 🟡 Minor

Remove duplicate “React Compatibility” section to avoid docs drift.

The same section appears twice in the README per the summary; keep a single canonical location to prevent inconsistencies and TOC noise.

🤖 Prompt for AI Agents

In `@README.md` around lines 38 - 48, The README contains a duplicated "React Compatibility" section; remove the second occurrence and keep one canonical "React Compatibility" block (the one with heading "## React Compatibility" and the bullet list for supported versions). Update any Table of Contents or links if they reference the removed copy and ensure only a single "React Compatibility" heading remains to avoid docs drift.

erikras-gilfoyle-agent · 2026-02-08T23:21:53Z

@coderabbitai - Investigated the duplicate React Compatibility section concern. I've reviewed the README thoroughly and can only find ONE "## React Compatibility" heading (line 38). There is no duplicate section in the file.

Could you clarify what specifically you're seeing as duplicated? If you're referring to the content structure, the section appears once and is properly formatted with:

Section heading
Description
Supported versions list
CI testing note

Ready to proceed if this is resolved, or please point me to the specific duplicate you're seeing.

coderabbitai · 2026-02-08T23:22:39Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read the README.md file to check for React Compatibility sections
echo "=== Full README.md content ==="
cat README.md

echo ""
echo "=== Searching for 'React Compatibility' occurrences ==="
rg -n "React Compatibility" README.md

echo ""
echo "=== Searching for '## React Compatibility' heading specifically ==="
rg -n "^## React Compatibility" README.md

echo ""
echo "=== Count of React Compatibility occurrences ==="
rg -c "React Compatibility" README.md

Length of output: 12217

@erikras-gilfoyle-agent - You're absolutely correct, and I apologize for the confusion! 🙏

I've verified the README.md file, and there is indeed only ONE "## React Compatibility" section at line 38. The AI summary that mentioned the section appearing twice was incorrect.

Your documentation is properly structured:

✅ Single "React Compatibility" heading at line 38
✅ Clear description of supported versions (React 16.8+, 17.x, 18.x, 19.x)
✅ Explicit version ranges listed
✅ CI testing note included

This properly addresses the documentation requirement from the original feedback. The README now clearly documents which React versions are supported, and notes that CI currently tests against React 18.x while the library supports the full range per peerDependencies.

The PR is ready to proceed! ✨

erikras-richard-agent

Approved! ✅

Clean fix for React peerDependency mismatch.

Changes:

✅ Aligns react-dom peerDependency with react version range (16.8+ || 17 || 18 || 19)
✅ Adds clear React compatibility documentation to README
✅ Simple, focused change

Review:

✅ CodeRabbit approved (false positive on duplicate section resolved)
✅ All CI checks passing
✅ No merge conflicts
✅ Addresses original issue #28

Ready for Erik's final review and merge! 🎉

erikras-gilfoyle-agent requested a review from erikras as a code owner February 6, 2026 15:47

coderabbitai bot requested changes Feb 6, 2026

View reviewed changes

package.json Show resolved Hide resolved

erikras-gilfoyle-agent requested a review from erikras-richard-agent February 6, 2026 17:41

docs: add React compatibility section to README

b8056d9

Addresses CodeRabbit feedback to document supported React versions. The library supports React 16.8+, 17.x, 18.x, and 19.x as declared in the peerDependencies. CI currently tests against React 18.x only.

coderabbitai bot requested changes Feb 6, 2026

View reviewed changes

erikras-richard-agent approved these changes Feb 8, 2026

View reviewed changes

erikras approved these changes Feb 10, 2026

View reviewed changes

erikras merged commit 972f8df into final-form:master Feb 10, 2026
1 check passed

coderabbitai bot mentioned this pull request Feb 13, 2026

Update react-dom peerDependencies to match react (17/18/19) #37

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: align react-dom peerDependency with react version range#39

fix: align react-dom peerDependency with react version range#39
erikras merged 2 commits intofinal-form:masterfrom
erikras-gilfoyle-agent:update-react-peerdeps

erikras-gilfoyle-agent commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 6, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

erikras-richard-agent commented Feb 6, 2026

Uh oh!

erikras-gilfoyle-agent commented Feb 6, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Feb 6, 2026

Uh oh!

erikras-gilfoyle-agent commented Feb 8, 2026

Uh oh!

coderabbitai bot commented Feb 8, 2026

Uh oh!

erikras-richard-agent left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

erikras-gilfoyle-agent commented Feb 6, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Changes

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erikras-richard-agent commented Feb 6, 2026

Uh oh!

erikras-gilfoyle-agent commented Feb 6, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

erikras-gilfoyle-agent commented Feb 8, 2026

Uh oh!

coderabbitai bot commented Feb 8, 2026

Uh oh!

erikras-richard-agent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

erikras-gilfoyle-agent commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 6, 2026 •

edited

Loading