Skip to content

Update React in peerDeps#28

Closed
MoltenCoffee wants to merge 1 commit intofinal-form:masterfrom
MoltenCoffee:master
Closed

Update React in peerDeps#28
MoltenCoffee wants to merge 1 commit intofinal-form:masterfrom
MoltenCoffee:master

Conversation

@MoltenCoffee
Copy link

@MoltenCoffee MoltenCoffee commented Nov 28, 2020

As mentioned in #27, with the new React version, this should probably be reflected in the peerDependencies as well. This PR does just that!

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #28 (368039c) into master (c21e696) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           41        41           
  Branches        17        17           
=========================================
  Hits            41        41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21e696...f01c12c. Read the comment docs.

@MoltenCoffee
Copy link
Author

MoltenCoffee commented Mar 4, 2021

@erikras I was wondering if you could have a look at this?

erikras-dinesh-agent pushed a commit that referenced this pull request Feb 4, 2026
Update react-dom peerDependencies to match react versions
3cce32f 
Closes #28
Closes #30

react-dom now supports React 17, 18, and 19 (matching react peerDeps).
@erikras-dinesh-agent erikras-dinesh-agent mentioned this pull request Feb 4, 2026
Open
@erikras-richard-agent
Copy link

erikras-richard-agent commented Feb 4, 2026

Thank you @MoltenCoffee for your patience with this PR from 2020!

Your contribution identified an important issue with React peerDependencies. After 5 years, we're finally addressing this properly.

Status: This PR is now superseded by #37 which updates React peerDependencies to support versions 16, 17, 18, and 19.

I recommend closing this PR in favor of #37. Thank you for your contribution to the Final Form ecosystem! 🙏

erikras-gilfoyle-agent pushed a commit to erikras-gilfoyle-agent/react-final-form-html5-validation that referenced this pull request Feb 6, 2026
fix: align react-dom peerDependency with react version range
12bb439 
Closes final-form#28
Closes final-form#30

The react peerDependency supports React 16.8+, 17, 18, and 19, but
react-dom was locked to ^18.2.0, causing peer dependency warnings for
users on React 17 and earlier.

This aligns react-dom to match the react version range, allowing the
library to work correctly across all supported React versions.
@erikras-gilfoyle-agent erikras-gilfoyle-agent mentioned this pull request Feb 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MoltenCoffee @erikras-richard-agent