Skip to content

fix(lightgbm): ensuring c++ resources created in swig are released after training #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artpdr merged 2 commits into from
May 20, 2026
Merged

fix(lightgbm): ensuring c++ resources created in swig are released after training #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c9ba77
fix(lightgbm): ensuring c++ resources created in swig are released af…
May 19, 2026
dc8db8f
chore(lightgbm-train): make swig variables final
May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 22 additions & 20 deletions ...n/java/com/feedzai/openml/provider/lightgbm/LightGBMBinaryClassificationModelTrainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,33 +148,35 @@ static void fit(final Dataset dataset,
final int numIterations = parseInt(params.get(NUM_ITERATIONS_PARAMETER_NAME));
logger.debug("LightGBM model trainParams: {}", trainParams);

final SWIGTrainData swigTrainData = new SWIGTrainData(
try (final SWIGTrainData swigTrainData = new SWIGTrainData(
numFeatures,
instancesPerChunk,
FairGBMParamParserUtil.isFairnessConstrained(params),
sampleWeightColIndex.isPresent()
);
final SWIGTrainBooster swigTrainBooster = new SWIGTrainBooster();
); final SWIGTrainBooster swigTrainBooster = new SWIGTrainBooster()) {
/// Create LightGBM dataset
final int constraintGroupColIndex = FairGBMParamParserUtil.getConstraintGroupColumnIndex(params, schema)
.orElse(FairGBMParamParserUtil.NO_SPECIFIC);

createTrainDataset(
dataset,
numFeatures,
trainParams,
constraintGroupColIndex,
sampleWeightColIndex,
swigTrainData
);

/// Create LightGBM dataset
final int constraintGroupColIndex = FairGBMParamParserUtil.getConstraintGroupColumnIndex(params, schema).orElse(
FairGBMParamParserUtil.NO_SPECIFIC);
createTrainDataset(
dataset,
numFeatures,
trainParams,
constraintGroupColIndex,
sampleWeightColIndex,
swigTrainData
);
/// Create Booster from dataset
createBoosterStructure(swigTrainBooster, swigTrainData, trainParams);
trainBooster(swigTrainBooster.swigBoosterHandle, numIterations);

/// Create Booster from dataset
createBoosterStructure(swigTrainBooster, swigTrainData, trainParams);
trainBooster(swigTrainBooster.swigBoosterHandle, numIterations);
/// Save model
saveModelFileToDisk(swigTrainBooster.swigBoosterHandle, outputModelFilePath);

/// Save model
saveModelFileToDisk(swigTrainBooster.swigBoosterHandle, outputModelFilePath);
swigTrainBooster.close(); // Explicitly release C++ resources right away. They're no longer needed.
// Note: By using try-with-resources, the call to both `swigTrainData.close()`
// and `swigTrainBooster.close()` to release C++ resources is guaranteed
}
}

/**
Expand Down
Loading