fix(lightgbm): ensuring c++ resources created in swig are released after training#150
Merged
Merged
Conversation
…ter training, even if an exception is thrown
AlbertoEAF
reviewed
May 20, 2026
AlbertoEAF
approved these changes
May 20, 2026
Contributor
AlbertoEAF
left a comment
There was a problem hiding this comment.
Great! Let's get this memleak fix merged in all pulses!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
============================================
+ Coverage 80.37% 81.37% +1.00%
- Complexity 469 519 +50
============================================
Files 48 52 +4
Lines 1620 1756 +136
Branches 157 177 +20
============================================
+ Hits 1302 1429 +127
- Misses 231 234 +3
- Partials 87 93 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a memory leak introduced in #147, by not ensuring the release of all allocated SWIG resources, in particular when training crashes (e.g., when an
IllegalArgumentExceptionis thrown due to negative sample weights provided). To ensure allocated resources are always released, a try-with-resources is used for the training logic, ensuring the call to.close()method for the two resources created -swigTrainDataandswigTrainBooster-, regardless if the training is successful or not