Only enable cmake response files on windows#26312
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Feb 20, 2026
Merged
Only enable cmake response files on windows#26312sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
This matches GCC and Clang do on in upstream/native CMake toolchains do:
```
Modules/Platform/Emscripten-Clang.cmake: set(CMAKE_${lang}_USE_RESPONSE_FILE_FOR_INCLUDES 1)
Modules/Platform/Windows-Clang.cmake: set(CMAKE_${lang}_USE_RESPONSE_FILE_FOR_INCLUDES 1)
Modules/Platform/Windows-Embarcadero.cmake: set(CMAKE_${lang}_USE_RESPONSE_FILE_FOR_INCLUDES 1)
Modules/Platform/Windows-GNU.cmake: set(CMAKE_${lang}_USE_RESPONSE_FILE_FOR_INCLUDES 1)
```
i.e. GCC and Clang don't use these settings except on windows.
Collaborator
Author
kripken
approved these changes
Feb 20, 2026
|
rb |
|
seems other cmake file use lang variable, maybe this can also use it |
Collaborator
Author
Yes, we could write a loop here I guess, but I think it would end up being about the same number of lines, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches GCC and Clang do on in upstream/native CMake toolchains do:
i.e. GCC and Clang don't use these settings except on windows.