Skip to content

Commit 88b2812

Browse files
authored
Only enable cmake response files on windows (#26312)
This matches GCC and Clang do on in upstream/native CMake toolchains do: ``` Modules/Platform/Emscripten-Clang.cmake: set(CMAKE_${lang}_USE_RESPONSE_FILE_FOR_INCLUDES 1) Modules/Platform/Windows-Clang.cmake: set(CMAKE_${lang}_USE_RESPONSE_FILE_FOR_INCLUDES 1) Modules/Platform/Windows-Embarcadero.cmake: set(CMAKE_${lang}_USE_RESPONSE_FILE_FOR_INCLUDES 1) Modules/Platform/Windows-GNU.cmake: set(CMAKE_${lang}_USE_RESPONSE_FILE_FOR_INCLUDES 1) ``` i.e. GCC and Clang don't use these settings except on windows.
1 parent 4156eea commit 88b2812

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

cmake/Modules/Platform/Emscripten.cmake

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -268,12 +268,15 @@ endif()
268268

269269
set(CMAKE_EXECUTABLE_SUFFIX ".js")
270270

271-
set(CMAKE_C_USE_RESPONSE_FILE_FOR_LIBRARIES 1)
272-
set(CMAKE_CXX_USE_RESPONSE_FILE_FOR_LIBRARIES 1)
273-
set(CMAKE_C_USE_RESPONSE_FILE_FOR_OBJECTS 1)
274-
set(CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS 1)
275-
set(CMAKE_C_USE_RESPONSE_FILE_FOR_INCLUDES 1)
276-
set(CMAKE_CXX_USE_RESPONSE_FILE_FOR_INCLUDES 1)
271+
if (CMAKE_HOST_WIN32)
272+
# See https://github.com/emscripten-core/emscripten/issues/2386
273+
set(CMAKE_C_USE_RESPONSE_FILE_FOR_LIBRARIES 1)
274+
set(CMAKE_CXX_USE_RESPONSE_FILE_FOR_LIBRARIES 1)
275+
set(CMAKE_C_USE_RESPONSE_FILE_FOR_OBJECTS 1)
276+
set(CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS 1)
277+
set(CMAKE_C_USE_RESPONSE_FILE_FOR_INCLUDES 1)
278+
set(CMAKE_CXX_USE_RESPONSE_FILE_FOR_INCLUDES 1)
279+
endif()
277280

278281
set(CMAKE_C_RESPONSE_FILE_LINK_FLAG "@")
279282
set(CMAKE_CXX_RESPONSE_FILE_LINK_FLAG "@")

0 commit comments

Comments
 (0)