Skip to content

fix(core): Fix validation errors for nested props of same name #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucas-koehler wants to merge 1 commit into
base: master
Choose a base branch
from
+511 −2
Open

fix(core): Fix validation errors for nested props of same name #2531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/core/src/util/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,15 @@ import { isOneOfEnumSchema } from './schema';
import filter from 'lodash/filter';
import isEqual from 'lodash/isEqual';

/**
* Checks for an additionally specified property that the error relates to.
* This may be added to an error's instancePath to show it add the violating property's control.
* For example, for required property errors, the instancePath points to the object containing the required property.
* The missing property's name is specified in the error's params.missingProperty field and returned by this function.
*
* @param error The ErrorObject to check for an additionally specified property that the error relates to
* @returns The invalid property name if present, otherwise undefined
*/
const getInvalidProperty = (error: ErrorObject): string | undefined => {
switch (error.keyword) {
case 'required':
Expand All @@ -51,12 +60,12 @@ export const getControlPath = (error: ErrorObject) => {
controlPath = controlPath.replace(/\//g, '.');

const invalidProperty = getInvalidProperty(error);
if (invalidProperty !== undefined && !controlPath.endsWith(invalidProperty)) {
if (invalidProperty !== undefined) {
controlPath = `${controlPath}.${invalidProperty}`;
}

// remove '.' chars at the beginning of paths
controlPath = controlPath.replace(/^./, '');
controlPath = controlPath.replace(/^\./, '');

// decode JSON Pointer escape sequences
controlPath = decode(controlPath);
Expand Down
Loading