Conversation
1497105 to
0fdc2d6
Compare
|
The PR seems to contain a commit that is not related (caching SPI change). Correct? In this case, can you please rebase your branch on the main branch? |
|
It's somehow related since it uses the async version of the cache API. I think we could rebase this one after merging #92 (that one is in progress) ? |
Does it require the Cache SPI changes or is it just because you started this PR off of your Cache SPI branch? |
|
I started it on the SPI branch - it can be reversed to the original cache API, but it will just look a bit different. |
Then yes, it's fine to rebase this one after #92 is merged |
|
Hi @wzy1935 , sorry for the delay. Would you have some time to rebase the PR? If not, I'll take it from here. Thanks |
Refers to issue #70.
Major changes in
CacheFilter.java, implemented 1, 2, 3, 4, 5 (partial), 6, 8, 9.(Implement 6 evolves with parts of 1 and 4 so they need to be done as well)
No test has been added/updated so far, so running the test will fail since the cache has different behaviors.