Update cache SPI and resource serialization#92
Merged
tsegismont merged 6 commits intoeclipse-vertx:mainfrom Jan 27, 2025
Merged
Update cache SPI and resource serialization#92tsegismont merged 6 commits intoeclipse-vertx:mainfrom
tsegismont merged 6 commits intoeclipse-vertx:mainfrom
Conversation
tsegismont
reviewed
Jul 17, 2024
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @wzy1935 ! I did a first round of comments
tsegismont
reviewed
Jul 26, 2024
Member
There was a problem hiding this comment.
Thank you @wzy1935 , I've added another batch of comments
Can you also add a test that verifies the behavior of a shared cached? That is, if it has stored a response for a one reverse proxy instance, another proxy instance will not have to contact the backend.
tsegismont
reviewed
Aug 8, 2024
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @wzy1935 ! Some more comments
vietj
reviewed
Aug 14, 2024
vietj
reviewed
Aug 14, 2024
Member
|
Can you please rebase this PR? Thank you |
frant-hartm
reviewed
Sep 12, 2024
tsegismont
reviewed
Sep 18, 2024
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @wzy1935 , another batch of reviews
Member
|
I went ahead and merged the PR (with a small renaming of a getter in Cache options) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
Updated the cache SPI and added serialization for the
Resourceclass.