Skip to content

remove double link #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RolandJentschETAS wants to merge 3 commits into
base: main
Choose a base branch
from
Open

remove double link #362

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c19f665
remove double link
RolandJentschETAS Jan 23, 2026
079d6e7
add deprtecate flag
RolandJentschETAS Jan 23, 2026
8bd767e
Merge branch 'main' into remove_double_comp_req_link
AlexanderLanin Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/extensions/score_metamodel/metamodel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,6 @@ needs_types:
# req-Id: tool_req__docs_common_attr_status
status: ^(valid|invalid)$
optional_links:
fulfils: comp_req
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this picture is still correct, then a 'includes' where 'comp' is allowed is missing here too right?
Or is that the 'consists_of' link here?

Copy link
Contributor Author

@RolandJentschETAS RolandJentschETAS Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the "consists_of". The picture in the process have to be adopted. There is a parallel PR in the process area for this.

Copy link
Member

@AlexanderLanin AlexanderLanin Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picture was updated

implements: logic_arc_int, real_arc_int_op
uses: logic_arc_int, real_arc_int_op
consists_of: comp
Expand All @@ -586,7 +585,7 @@ needs_types:
optional_links:
fulfils: comp_req
implements: logic_arc_int, real_arc_int_op # deprecated, views does not implement anything. Now moved to comp
includes: comp
includes: comp # deprecated
uses: logic_arc_int, real_arc_int_op
belongs_to: comp # TODO: make it mandatory
tags:
Expand Down
Loading