Skip to content

Allow customizing CommonTab #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
trancexpress wants to merge 1 commit into
base: master
Choose a base branch
from
+28 −14
Draft

Allow customizing CommonTab #2676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 28 additions & 14 deletions debug/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/CommonTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,9 @@ IDialogSettings getDialogBoundsSettings(String id) {
/**
* Creates the favorites control
* @param parent the parent composite to add this one to
* @since 3.2
* @since 3.21
Copy link
Copy Markdown
Contributor

@merks merks May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 3.3?

I don’t see any version increment anywhere.

Copy link
Copy Markdown
Contributor Author

@trancexpress trancexpress May 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did increment to 3.22 and tried using that for the @since, but the tooling complained:

Description	Resource	Location	Path	Type
The minor version is increased unnecessarily since either the major or minor version is already increased	MANIFEST.MF	line 5	/org.eclipse.debug.ui/META-INF	Version Numbering Problem

So I'm not sure. The current version is 3.21.

Copy link
Copy Markdown
Contributor

@merks merks May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodness knows why a private method has a since annotation. In any case, when master opens there will be a new baseline and then the version will need to increase. The since annotations will need to match that new version.

*/
private void createFavoritesComponent(Composite parent) {
protected void createFavoritesComponent(Composite parent) {
Group favComp = SWTFactory.createGroup(parent, LaunchConfigurationsMessages.CommonTab_Display_in_favorites_menu__10, 1, 1, GridData.FILL_BOTH);
fFavoritesTable = CheckboxTableViewer.newCheckList(favComp, SWT.CHECK | SWT.BORDER | SWT.MULTI | SWT.FULL_SELECTION);
Control table = fFavoritesTable.getControl();
Expand All @@ -222,9 +222,9 @@ private void createFavoritesComponent(Composite parent) {
/**
* Creates the shared config component
* @param parent the parent composite to add this component to
* @since 3.2
* @since 3.21
*/
private void createSharedConfigComponent(Composite parent) {
protected void createSharedConfigComponent(Composite parent) {
Group group = SWTFactory.createGroup(parent, LaunchConfigurationsMessages.CommonTab_0, 3, 2, GridData.FILL_HORIZONTAL);
Composite comp = SWTFactory.createComposite(group, parent.getFont(), 3, 3, GridData.FILL_BOTH, 0, 0);
fLocalRadioButton = createRadioButton(comp, LaunchConfigurationsMessages.CommonTab_L_ocal_3);
Expand Down Expand Up @@ -660,6 +660,24 @@ private IContainer getContainer(String path) {

@Override
public void initializeFrom(ILaunchConfiguration configuration) {
updateSharedConfig(configuration);
updateFavoritesFromConfig(configuration);
updateLaunchInBackground(configuration);
updateEncoding(configuration);
updateConsoleOutput(configuration);

boolean terminateDescendants = getAttribute(configuration, DebugPlugin.ATTR_TERMINATE_DESCENDANTS, true);
fTerminateDescendantsButton.setSelection(terminateDescendants);
}

/**
* Updates a configuration with the values set in the section for shared
* configurations.
*
* @param configuration the configuration to update
* @since 3.21
*/
protected void updateSharedConfig(ILaunchConfiguration configuration) {
boolean isShared = !configuration.isLocal();
fSharedRadioButton.setSelection(isShared);
fLocalRadioButton.setSelection(!isShared);
Expand All @@ -676,13 +694,6 @@ public void initializeFrom(ILaunchConfiguration configuration) {
}
fSharedLocationText.setText(containerName);
}
updateFavoritesFromConfig(configuration);
updateLaunchInBackground(configuration);
updateEncoding(configuration);
updateConsoleOutput(configuration);

boolean terminateDescendants = getAttribute(configuration, DebugPlugin.ATTR_TERMINATE_DESCENDANTS, true);
fTerminateDescendantsButton.setSelection(terminateDescendants);
}

/**
Expand Down Expand Up @@ -802,9 +813,10 @@ public static boolean isLaunchInBackground(ILaunchConfiguration configuration) {
/**
* Updates the favorites selections from the local configuration
* @param config the local configuration
* @since 3.21
*/
@SuppressWarnings("deprecation")
private void updateFavoritesFromConfig(ILaunchConfiguration config) {
protected void updateFavoritesFromConfig(ILaunchConfiguration config) {
fFavoritesTable.setInput(config);
fFavoritesTable.setCheckedElements(new Object[]{});
List<String> groups = getAttribute(config, IDebugUIConstants.ATTR_FAVORITE_GROUPS, new ArrayList<>());
Expand Down Expand Up @@ -833,8 +845,9 @@ private void updateFavoritesFromConfig(ILaunchConfiguration config) {
/**
* Updates the configuration form the local shared config working copy
* @param config the local shared config working copy
* @since 3.21
*/
private void updateConfigFromLocalShared(ILaunchConfigurationWorkingCopy config) {
protected void updateConfigFromLocalShared(ILaunchConfigurationWorkingCopy config) {
if (isShared()) {
String containerPathString = fSharedLocationText.getText();
IContainer container = getContainer(containerPathString);
Expand Down Expand Up @@ -865,9 +878,10 @@ protected LaunchConfigurationManager getLaunchConfigurationManager() {
* when comparing if content is equal, since 'false' is default
* and will be missing for older configurations.
* @param config the configuration to update
* @since 3.21
*/
@SuppressWarnings("deprecation")
private void updateConfigFromFavorites(ILaunchConfigurationWorkingCopy config) {
protected void updateConfigFromFavorites(ILaunchConfigurationWorkingCopy config) {
Object[] checked = fFavoritesTable.getCheckedElements();
boolean debug = getAttribute(config, IDebugUIConstants.ATTR_DEBUG_FAVORITE, false);
boolean run = getAttribute(config, IDebugUIConstants.ATTR_RUN_FAVORITE, false);
Expand Down
Loading