Allow customizing CommonTab#2676
Draft
trancexpress wants to merge 1 commit into
Draft
Conversation
Open up CommonTab for overriding methods, to customize what elements are shown in the UI. This allows to e.g. hide common tab elements that are not relevant for custom launch types. Fixes: eclipse-platform#2675
merks
reviewed
May 26, 2026
| * Creates the favorites control | ||
| * @param parent the parent composite to add this one to | ||
| * @since 3.2 | ||
| * @since 3.21 |
Contributor
There was a problem hiding this comment.
Should this be 3.3?
I don’t see any version increment anywhere.
Contributor
Author
There was a problem hiding this comment.
I did increment to 3.22 and tried using that for the @since, but the tooling complained:
Description Resource Location Path Type
The minor version is increased unnecessarily since either the major or minor version is already increased MANIFEST.MF line 5 /org.eclipse.debug.ui/META-INF Version Numbering Problem
So I'm not sure. The current version is 3.21.
Contributor
There was a problem hiding this comment.
Goodness knows why a private method has a since annotation. In any case, when master opens there will be a new baseline and then the version will need to increase. The since annotations will need to match that new version.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open up
CommonTabfor overriding methods, to customize what elements are shown in the UI. This allows to e.g. hide common tab elements that are not relevant for custom launch types.Fixes: #2675