-
Notifications
You must be signed in to change notification settings - Fork 17
New Footer reimplementation #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
cf79632
First approach to the new footer component
PelayoFelgueroso b22c454
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
PelayoFelgueroso f6c2365
Update footer styles: change social icon fill color and adjust link c…
PelayoFelgueroso 26f72ae
Remove unnecesary change
PelayoFelgueroso 1c43b59
Refactor footer component styles for improved responsiveness and layo…
PelayoFelgueroso 1acbd0a
Remove href from Logo type, add changes to types in FooterCodePage an…
PelayoFelgueroso b789648
Fix Left and Right container responsive styles
PelayoFelgueroso e37f29d
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
PelayoFelgueroso 9963ffc
Add responsive styles and fix stories with new footer version
PelayoFelgueroso d7b5c5f
Update tests of footer component
PelayoFelgueroso 0437b2d
Fix accessibility tests for footer
PelayoFelgueroso ec8a32a
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
PelayoFelgueroso 7e4f6e8
Add getContrastColor funcionality to the footer and its correspondig …
PelayoFelgueroso a311085
Add same doc updates
PelayoFelgueroso 3248541
Remove styled component for BottomLink and add DxcLink instead
PelayoFelgueroso 1bebb0c
Update documentation and bottomLink states
PelayoFelgueroso 97e1c06
Fix some minor ActionIcon issues found and removed unused prop to Soc…
PelayoFelgueroso 364585f
Hide bottomLinks and Copyright when overflow on desktop version
PelayoFelgueroso a90564f
Removed ActionIcon unnecesary changes
PelayoFelgueroso 93292d0
Merge branch 'master' into PelayoFelgueroso/footer-reimplementation
PelayoFelgueroso fff2908
Merge branch 'master' into PelayoFelgueroso/footer-reimplementation
PelayoFelgueroso 31782be
Merge branch 'master' into PelayoFelgueroso/footer-reimplementation
PelayoFelgueroso 07eabd0
Fix css based on feedback
PelayoFelgueroso 2ecbb3f
Add ResizeObserver to tests
PelayoFelgueroso 7f58ab3
Add ResizeObserver to accesibility tests
PelayoFelgueroso 0c23a7a
Fix logo function
PelayoFelgueroso 7426be0
Fix based on comments
PelayoFelgueroso b4dd815
Fix latest comments
PelayoFelgueroso a5318d6
Fix SocialLinks container height
PelayoFelgueroso 546c8a1
Remove unnecesary fill
PelayoFelgueroso ae85140
Fix outline for socialLinks
PelayoFelgueroso b7e5cca
Merge branch 'master' into PelayoFelgueroso/footer-reimplementation
PelayoFelgueroso a56d6cf
Fix dimensions-28 variable to height-s
PelayoFelgueroso 25be6e0
Merge branch 'master' into PelayoFelgueroso/footer-reimplementation
PelayoFelgueroso 1e905ae
Fix svg colors and add stories
PelayoFelgueroso 6d720b3
Merge branch 'PelayoFelgueroso/footer-reimplementation' of https://gi…
PelayoFelgueroso 146e134
Fix logo in header of stories
PelayoFelgueroso fb77e17
Fix based on comments
PelayoFelgueroso e51368d
Fix overview removing incorrect statements
PelayoFelgueroso e63d07e
Remove margin from footer
PelayoFelgueroso e2e4168
Merge branch 'master' into PelayoFelgueroso/footer-reimplementation
PelayoFelgueroso 778a251
Add target blank to socialLinks
PelayoFelgueroso f83bbc2
Merge branch 'PelayoFelgueroso/footer-reimplementation' of https://gi…
PelayoFelgueroso dfbcdf0
Add stories and remove margin from accessibility test
PelayoFelgueroso fdb31a3
Update documentation statements
PelayoFelgueroso 4c99805
Change compound component for props
PelayoFelgueroso 1d21871
Normalize media querys
PelayoFelgueroso 20d5cd5
Merge branch 'master' into PelayoFelgueroso/footer-reimplementation
PelayoFelgueroso d40ce06
Remove margin from test and add reduced mode story in layout
PelayoFelgueroso ace7dac
Remove with navigation from overview page
PelayoFelgueroso d22b63b
Change footer overview page
PelayoFelgueroso ce01c9d
Add font tokens to BottomLinks and change tabIndex text
PelayoFelgueroso 3659ae4
Merge branch 'PelayoFelgueroso/footer-reimplementation' of https://gi…
PelayoFelgueroso d2ad3d0
Enhance footer overview with additional content and update variant te…
PelayoFelgueroso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
PelayoFelgueroso marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PelayoFelgueroso marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+7.5 KB
(120%)
apps/website/screens/components/footer/overview/images/footer_anatomy.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-40.6 KB
(47%)
apps/website/screens/components/footer/overview/images/footer_variants.png
PelayoFelgueroso marked this conversation as resolved.
Show resolved
Hide resolved
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.