Skip to content

New Footer reimplementation #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jialecl merged 54 commits into from
Nov 24, 2025
Merged

New Footer reimplementation #2326

Jialecl merged 54 commits into from
Nov 24, 2025

Conversation

@PelayoFelgueroso
Copy link
Collaborator

@PelayoFelgueroso PelayoFelgueroso commented Nov 5, 2025 •
edited
Loading

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
New footer reimplementation based on the new design.

@PelayoFelgueroso
First approach to the new footer component
cf79632
@PelayoFelgueroso
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
b22c454 
…eact into PelayoFelgueroso/footer-reimplementation
@PelayoFelgueroso
Update footer styles: change social icon fill color and adjust link c…
f6c2365 
…olors for better visibility
@PelayoFelgueroso
Remove unnecesary change
26f72ae
@PelayoFelgueroso
Refactor footer component styles for improved responsiveness and layo…
1c43b59 
…ut consistency
@PelayoFelgueroso
Remove href from Logo type, add changes to types in FooterCodePage an…
1acbd0a 
…d add Compound components. Also improve responsive styles for Left and Right Contianers.
@PelayoFelgueroso
Fix Left and Right container responsive styles
b789648
@PelayoFelgueroso
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
e37f29d 
…eact into PelayoFelgueroso/footer-reimplementation
@PelayoFelgueroso
Add responsive styles and fix stories with new footer version
9963ffc
@PelayoFelgueroso
Update tests of footer component
d7b5c5f
@PelayoFelgueroso
Fix accessibility tests for footer
0437b2d
@PelayoFelgueroso
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
ec8a32a 
…eact into PelayoFelgueroso/footer-reimplementation
@PelayoFelgueroso
Add getContrastColor funcionality to the footer and its correspondig …
7e4f6e8 
…tests
@PelayoFelgueroso
Add same doc updates
a311085
@PelayoFelgueroso
Remove styled component for BottomLink and add DxcLink instead
3248541
@PelayoFelgueroso
Update documentation and bottomLink states
1bebb0c
@PelayoFelgueroso
Fix some minor ActionIcon issues found and removed unused prop to Soc…
97e1c06 
…ialAnchor styled component in footer
@PelayoFelgueroso
Hide bottomLinks and Copyright when overflow on desktop version
364585f
@PelayoFelgueroso PelayoFelgueroso marked this pull request as ready for review November 10, 2025 09:22
@Jialecl Jialecl self-requested a review November 18, 2025 15:32
@Jialecl Jialecl self-assigned this Nov 18, 2025
Jialecl
Jialecl reviewed Nov 19, 2025
View reviewed changes
Jialecl
Jialecl reviewed Nov 20, 2025
View reviewed changes
Jialecl
Jialecl reviewed Nov 20, 2025
View reviewed changes
@PelayoFelgueroso
Fix based on comments
fb77e17
@PelayoFelgueroso
Fix overview removing incorrect statements
e51368d
@PelayoFelgueroso
Remove margin from footer
e63d07e
@PelayoFelgueroso
Merge branch 'master' into PelayoFelgueroso/footer-reimplementation
e2e4168
@PelayoFelgueroso
Add target blank to socialLinks
778a251
@PelayoFelgueroso
Merge branch 'PelayoFelgueroso/footer-reimplementation' of https://gi…
f83bbc2 
…thub.com/dxc-technology/halstack-react into PelayoFelgueroso/footer-reimplementation
@PelayoFelgueroso
Add stories and remove margin from accessibility test
dfbcdf0
@PelayoFelgueroso
Update documentation statements
fdb31a3
@PelayoFelgueroso
Change compound component for props
4c99805
@PelayoFelgueroso
Normalize media querys
1d21871
@PelayoFelgueroso
Merge branch 'master' into PelayoFelgueroso/footer-reimplementation
20d5cd5
@PelayoFelgueroso
Remove margin from test and add reduced mode story in layout
d40ce06
@PelayoFelgueroso
Remove with navigation from overview page
ace7dac
@PelayoFelgueroso
Change footer overview page
d22b63b
Jialecl
Jialecl reviewed Nov 21, 2025
View reviewed changes
@Jialecl Jialecl merged commit ba4b4fd into master Nov 24, 2025
5 checks passed
@Jialecl Jialecl deleted the PelayoFelgueroso/footer-reimplementation branch November 24, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PelayoFelgueroso @Jialecl