-
Notifications
You must be signed in to change notification settings - Fork 17
Bleed redesign #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bleed redesign #2163
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
dea471e
Reimplementation of the Bleed component with new CSS variables
2ad6251
Prepared structure for new documentation
91eed76
Fixed props order and github links
b221644
Fixed text for export
affb502
Merge branch 'master' into Mil4n0r/tokens-bleed
Mil4n0r 49b6ecd
Converted to inline function
f5bafff
Merge branch 'Mil4n0r/tokens-bleed' of github.com:dxc-technology/hals…
499d36c
Merge branch 'master' of github.com:dxc-technology/halstack-react int…
1e87a59
Refactored bleed
4e1c3f1
Fixed margin values
bf9bff7
Added documentation
85bb349
Document formatting
a1fa460
Inset updates to stay consistent
GomezIvann a9659e4
Fixed examples and negative value behavior
090ba6a
Merge branch 'Mil4n0r/tokens-bleed' of github.com:dxc-technology/hals…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import Head from "next/head"; | ||
| import type { ReactElement } from "react"; | ||
| import BleedPageLayout from "screens/components/bleed/BleedPageLayout"; | ||
| import BleedCodePage from "screens/components/bleed/code/BleedCodePage"; | ||
|
|
||
| const Code = () => { | ||
| return ( | ||
| <> | ||
| <Head> | ||
| <title>Bleed Code — Halstack Design System</title> | ||
| </Head> | ||
| <BleedCodePage /> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| Code.getLayout = (page: ReactElement) => <BleedPageLayout>{page}</BleedPageLayout>; | ||
|
|
||
| export default Code; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,19 @@ | ||
| import Head from "next/head"; | ||
| import type { ReactElement } from "react"; | ||
| import BleedPageLayout from "screens/components/bleed/BleedPageLayout"; | ||
| import BleedCodePage from "screens/components/bleed/code/BleedCodePage"; | ||
| import BleedOverviewPage from "screens/components/bleed/overview/BleedOverviewPage"; | ||
|
|
||
| const Index = () => { | ||
| return ( | ||
| <> | ||
| <Head> | ||
| <title>Bleed — Halstack Design System</title> | ||
| </Head> | ||
| <BleedCodePage></BleedCodePage> | ||
| <BleedOverviewPage /> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| Index.getLayout = function getLayout(page: ReactElement) { | ||
| return <BleedPageLayout>{page}</BleedPageLayout>; | ||
| }; | ||
| Index.getLayout = (page: ReactElement) => <BleedPageLayout>{page}</BleedPageLayout>; | ||
|
|
||
| export default Index; |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
apps/website/screens/components/bleed/overview/BleedOverviewPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import { DxcBulletedList, DxcFlex, DxcLink, DxcParagraph } from "@dxc-technology/halstack-react"; | ||
| import QuickNavContainerLayout from "@/common/QuickNavContainerLayout"; | ||
| import QuickNavContainer from "@/common/QuickNavContainer"; | ||
| import DocFooter from "@/common/DocFooter"; | ||
| import Link from "next/link"; | ||
|
|
||
| const sections = [ | ||
| { | ||
| title: "Introduction", | ||
| content: ( | ||
| <> | ||
| <DxcParagraph> | ||
| The bleed component is a container that applies negative margins around its content, allowing elements to | ||
| extend beyond their usual boundaries. This can be useful for aligning content seamlessly and creating dynamic, | ||
| edge-to-edge layouts. It provides customizable spacing options, offering greater design flexibility while | ||
| maintaining visual coherence. | ||
| </DxcParagraph> | ||
| </> | ||
| ), | ||
| }, | ||
| { | ||
| title: "Best practices", | ||
| content: ( | ||
| <DxcBulletedList> | ||
| <DxcBulletedList.Item> | ||
| <strong>Enhance visual flow:</strong> use the bleed component to create smooth transitions between sections, | ||
| removing unwanted spacing restrictions. | ||
| </DxcBulletedList.Item> | ||
| <DxcBulletedList.Item> | ||
| <strong>Maintain balance and aesthetics:</strong> choose appropriate spacing values to ensure a | ||
| well-proportioned and visually appealing design. | ||
| </DxcBulletedList.Item> | ||
| <DxcBulletedList.Item> | ||
| <strong>Avoid unnecessary clutter:</strong> excessive use of the Inset component may lead to a fragmented or | ||
| overcrowded layout. | ||
| </DxcBulletedList.Item> | ||
| <DxcBulletedList.Item> | ||
| <strong>Ensure consistency with design tokens:</strong> whenever possible, use the design tokens provided by | ||
| the Halstack Design System, to maintain visual and functional consistency across applications, even though the | ||
| component allows custom values. | ||
| </DxcBulletedList.Item> | ||
| <DxcBulletedList.Item> | ||
| <strong>Combine with other layout techniques:</strong> use this component alongside{" "} | ||
| <Link href="/components/flex" passHref legacyBehavior> | ||
| <DxcLink>flex</DxcLink> | ||
| </Link>{" "} | ||
| and{" "} | ||
| <Link href="/components/grid" passHref legacyBehavior> | ||
| <DxcLink>grid</DxcLink> | ||
| </Link>{" "} | ||
| components to create consistent and semantic layouts. | ||
| </DxcBulletedList.Item> | ||
| </DxcBulletedList> | ||
| ), | ||
| }, | ||
| ]; | ||
|
|
||
| const BleedOverviewPage = () => ( | ||
| <DxcFlex direction="column" gap="4rem"> | ||
| <QuickNavContainerLayout> | ||
| <QuickNavContainer sections={sections} startHeadingLevel={2} /> | ||
| </QuickNavContainerLayout> | ||
| <DocFooter githubLink="https://github.com/dxc-technology/halstack-react/blob/master/apps/website/screens/components/bleed/overview/BleedOverviewPage.tsx" /> | ||
| </DxcFlex> | ||
| ); | ||
|
|
||
| export default BleedOverviewPage; |
36 changes: 0 additions & 36 deletions
36
apps/website/screens/components/bleed/specs/BleedSpecsPage.tsx
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.