Skip to content

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Feb 18, 2025

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Redesign of the bleed component following the new design kit specifications, already using the new token architecture (CSS variables).

Additional context

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Feb 18, 2025

Missing documentation

@GomezIvann GomezIvann self-assigned this Mar 5, 2025
@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Mar 10, 2025

I would like to discuss these remaining points with the designers as well.

Copy link
Collaborator

@GomezIvann GomezIvann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In the Bleed.stories.tsx file, replace Container and Placeholder with the same code as in the Inset please! To remove the older design token values. Also, a lot of the example from the stories can be removed since they are redundant with the new string type.
  • Update the doc example using the new CSS variables when possible.
  • Now that we have experience with both the Inset, Flex and Grid, I feel confident we can address the docs from the Bleed!

GomezIvann
GomezIvann previously approved these changes Apr 3, 2025
@GomezIvann GomezIvann merged commit 29029d9 into master Apr 3, 2025
4 checks passed
@GomezIvann GomezIvann deleted the Mil4n0r/tokens-bleed branch April 3, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants