Skip to content

Several updates & fixes in Halstack #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mil4n0r merged 8 commits into from
Jan 13, 2025
Merged

Several updates & fixes in Halstack #2134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4671106
Several updates & fixes
GomezIvann Jan 9, 2025
27d4436
Updates to the FileInput and the Progress Bar
GomezIvann Jan 9, 2025
8d2139c
Restored aria-label from Dialog
GomezIvann Jan 10, 2025
12c5216
Fixed accessibility issues
GomezIvann Jan 10, 2025
6d6f800
Adding valid role to file item
GomezIvann Jan 10, 2025
c95b00a
Merge branch 'master' into gomezivann/several-updates
Mil4n0r Jan 13, 2025
e4c4c42
Updates based on feedback
GomezIvann Jan 13, 2025
d7324e2
Merge branch 'gomezivann/several-updates' of https://github.com/dxc-t…
GomezIvann Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions apps/website/screens/common/themes/advanced-theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,15 +403,8 @@
"dialog": {
"overlayColor": "#000000b3",
"backgroundColor": "#ffffff",
"closeIconSize": "24px",
"closeIconTopPosition": "20px",
"closeIconRightPosition": "20px",
"closeIconBackgroundColor": "transparent",
"closeIconBorderColor": "none",
"closeIconColor": "#000000",
"closeIconBorderThickness": "0px",
"closeIconBorderStyle": "solid",
"closeIconBorderRadius": "2px",
"boxShadowOffsetX": "0px",
"boxShadowOffsetY": "1px",
"boxShadowBlur": "3px",
Expand Down Expand Up @@ -546,15 +539,15 @@
},
"header": {
"backgroundColor": "#ffffff",
"hamburguerFocusColor": "#0095ff",
"hamburguerFontFamily": "Open Sans, sans-serif",
"hamburguerFontStyle": "normal",
"hamburguerFontColor": "#000000",
"hamburguerFontSize": "10px",
"hamburguerFontWeight": "600",
"hamburguerTextTransform": "uppercase",
"hamburguerIconColor": "#000000",
"hamburguerHoverColor": "#e6e6e6",
"hamburgerFocusColor": "#0095ff",
"hamburgerFontFamily": "Open Sans, sans-serif",
"hamburgerFontStyle": "normal",
"hamburgerFontColor": "#000000",
"hamburgerFontSize": "10px",
"hamburgerFontWeight": "600",
"hamburgerTextTransform": "uppercase",
"hamburgerIconColor": "#000000",
"hamburgerHoverColor": "#e6e6e6",
"logo": "",
"logoResponsive": "",
"logoHeight": "40px",
Expand Down
2 changes: 1 addition & 1 deletion apps/website/screens/common/themes/opinionated-theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"accentColor": "#000000",
"fontColor": "#000000",
"menuBaseColor": "#ffffff",
"hamburguerColor": "#000000",
"hamburgerColor": "#000000",
"logo": "/dxc_header_logo.svg",
"logoResponsive": "/dxc_header_logo.svg",
"contentColor": "#000000",
Expand Down
4 changes: 3 additions & 1 deletion apps/website/screens/components/accordion/code/AccordionCodePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ const sections = [
<TableCode>boolean</TableCode>
</td>
<td>Initial state of the panel, only when it is uncontrolled.</td>
<td>-</td>
<td>
<TableCode>false</TableCode>
</td>
</tr>
<tr>
<td>isExpanded</td>
Expand Down
2 changes: 1 addition & 1 deletion apps/website/screens/components/checkbox/code/CheckboxCodePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const sections = [
managed internally by the component.
</td>
<td>
<TableCode>false</TableCode>
-
</td>
</tr>
<tr>
Expand Down
50 changes: 0 additions & 50 deletions apps/website/screens/components/dialog/specs/DialogSpecsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,6 @@ const sections = [
</td>
<td>transparent</td>
</tr>
<tr>
<td>
<Code>closeIconBorderColor</Code>
</td>
<td>Icon close</td>
<td>-</td>
<td>-</td>
</tr>
</tbody>
</DxcTable>
),
Expand Down Expand Up @@ -161,48 +153,6 @@ const sections = [
title: "Border",
content: (
<>
<DxcTable>
<thead>
<tr>
<th>Component token</th>
<th>Element</th>
<th>Core token</th>
<th>Value</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<Code>closeIconBorderThickness</Code>
</td>
<td>Icon close</td>
<td>
<Code>border-width-0</Code>
</td>
<td>0px</td>
</tr>
<tr>
<td>
<Code>closeIconBorderStyle</Code>
</td>
<td>Icon close</td>
<td>
<Code>border-style-solid</Code>
</td>
<td>solid</td>
</tr>
<tr>
<td>
<Code>closeIconBorderRadius</Code>
</td>
<td>Icon close</td>
<td>
<Code>border-radius-small</Code>
</td>
<td>0.125rem / 2px</td>
</tr>
</tbody>
</DxcTable>
<DxcTable>
<thead>
<tr>
Expand Down
16 changes: 8 additions & 8 deletions apps/website/screens/components/header/specs/HeaderSpecsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const sections = [
</tr>
<tr>
<td>
<Code>hamburguerHoverColor</Code>
<Code>hamburgerHoverColor</Code>
</td>
<td>Menu:hover</td>
<td>
Expand All @@ -90,7 +90,7 @@ const sections = [
</tr>
<tr>
<td>
<Code>hamburguerFocusColor</Code>
<Code>hamburgerFocusColor</Code>
</td>
<td>Menu:focus</td>
<td>
Expand All @@ -100,7 +100,7 @@ const sections = [
</tr>
<tr>
<td>
<Code>hamburguerFontColor</Code>
<Code>hamburgerFontColor</Code>
</td>
<td>Menu label</td>
<td>
Expand All @@ -110,7 +110,7 @@ const sections = [
</tr>
<tr>
<td>
<Code>hamburguerIconColor</Code>
<Code>hamburgerIconColor</Code>
</td>
<td>Menu icon</td>
<td>
Expand Down Expand Up @@ -157,7 +157,7 @@ const sections = [
<tbody>
<tr>
<td>
<Code>hamburguerFontFamily</Code>
<Code>hamburgerFontFamily</Code>
</td>
<td>Menu label</td>
<td>
Expand All @@ -167,7 +167,7 @@ const sections = [
</tr>
<tr>
<td>
<Code>hamburguerFontStyle</Code>
<Code>hamburgerFontStyle</Code>
</td>
<td>Menu label</td>
<td>
Expand All @@ -177,7 +177,7 @@ const sections = [
</tr>
<tr>
<td>
<Code>hamburguerFontSize</Code>
<Code>hamburgerFontSize</Code>
</td>
<td>Menu label</td>
<td>
Expand All @@ -187,7 +187,7 @@ const sections = [
</tr>
<tr>
<td>
<Code>hamburguerFontWeight</Code>
<Code>hamburgerFontWeight</Code>
</td>
<td>Menu label</td>
<td>
Expand Down
2 changes: 1 addition & 1 deletion apps/website/screens/components/progress-bar/code/ProgressBarCodePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const sections = [
<td>
<TableCode>boolean</TableCode>
</td>
<td>If true, the value is displayed above the progress bar.</td>
<td>If true, the determined value is displayed above the progress bar.</td>
<td>
<TableCode>false</TableCode>
</td>
Expand Down
3 changes: 1 addition & 2 deletions apps/website/screens/components/progress-bar/code/examples/overlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@ const code = `() => {
label="Show Progress Bar for 3 seconds"
onClick={showModal}
/>

{isVisible && (
<DxcProgressBar
label="Loading"
overlay={true}
overlay
/>
)}
</DxcFlex>
Expand Down
8 changes: 4 additions & 4 deletions apps/website/screens/components/switch/code/SwitchCodePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ const sections = [
<TableCode>boolean</TableCode>
</td>
<td>Initial state of the switch, only when it is uncontrolled.</td>
<td>-</td>
<td>
<TableCode>false</TableCode>
</td>
</tr>
<tr>
<td>checked</td>
Expand All @@ -39,9 +41,7 @@ const sections = [
If true, the component is checked. If undefined, the component will be uncontrolled and the checked
attribute will be managed internally by the component.
</td>
<td>
<TableCode>false</TableCode>
</td>
<td>-</td>
</tr>
<tr>
<td>value</td>
Expand Down
8 changes: 8 additions & 0 deletions apps/website/screens/components/toast/code/ToastCodePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ const sections = [
<TableCode>3000</TableCode>
</td>
</tr>
<tr>
<td>children</td>
<td>
<TableCode>ReactNode</TableCode>
</td>
<td>Tree of components from which the <Code>useToast</Code> hook can be triggered.</td>
<td>-</td>
</tr>
</tbody>
</DxcTable>
),
Expand Down
8 changes: 4 additions & 4 deletions apps/website/screens/components/wizard/code/WizardCodePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ const sections = [
<TableCode>number</TableCode>
</td>
<td>Initially selected step, only when it is uncontrolled.</td>
<td>-</td>
<td>
<TableCode>0</TableCode>
</td>
</tr>
<tr>
<td>currentStep</td>
Expand All @@ -41,9 +43,7 @@ const sections = [
Defines which step is marked as the current. The numeration starts at 0. If undefined, the component will
be uncontrolled and the step will be managed internally by the component.
</td>
<td>
<TableCode>0</TableCode>
</td>
<td>-</td>
</tr>
<tr>
<td>mode</td>
Expand Down
2 changes: 1 addition & 1 deletion apps/website/screens/principles/localization/LocalizationPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ const sections = [
</tr>
<tr>
<td>
<Code>hamburguerTitle</Code>
<Code>hamburgerTitle</Code>
</td>
<td>Menu</td>
</tr>
Expand Down
8 changes: 4 additions & 4 deletions apps/website/screens/principles/themes/ThemesPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ const sections = [
<tr>
<td>Font color</td>
<td>
<Code>hamburguerFontColor</Code>
<Code>hamburgerFontColor</Code>
</td>
</tr>
<tr>
Expand All @@ -681,12 +681,12 @@ const sections = [
</td>
</tr>
<tr>
<td>Hamburguer color</td>
<td>Hamburger color</td>
<td>
<Code>hamburguerIconColor</Code>
<Code>hamburgerIconColor</Code>
<br />
<br />
<Code>hamburguerHoverColor</Code> (+90% of lightness)
<Code>hamburgerHoverColor</Code> (+90% of lightness)
</td>
</tr>
<tr>
Expand Down
2 changes: 1 addition & 1 deletion apps/website/screens/principles/themes/examples/bloomTheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default {
accentColor: "#000000",
fontColor: "#000000",
menuBaseColor: "#ffffff",
hamburguerColor: "#000000",
hamburgerColor: "#000000",
logo: "https://assure.proxy.lambda/image/image_1674206652560.jpg",
logoResponsive: "https://assure.proxy.lambda/image/image_1674206660896.jpg",
contentColor: "#000000",
Expand Down
25 changes: 9 additions & 16 deletions apps/website/screens/theme-generator/themes/schemas/advanced.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,15 +403,8 @@
"dialog": {
"overlayColor": "color",
"backgroundColor": "color",
"closeIconSize": "length",
"closeIconTopPosition": "length",
"closeIconRightPosition": "length",
"closeIconBackgroundColor": "color",
"closeIconColor": "color",
"closeIconBorderColor": "color",
"closeIconBorderThickness": "bWidth",
"closeIconBorderStyle": "bStyle",
"closeIconBorderRadius": "length",
"boxShadowOffsetX": "length",
"boxShadowOffsetY": "length",
"boxShadowBlur": "length",
Expand Down Expand Up @@ -548,13 +541,13 @@
"backgroundColor": "color",
"underlinedColor": "color",
"menuBackgroundColor": "color",
"hamburguerIconColor": "color",
"hamburguerHoverColor": "color",
"hamburgerIconColor": "color",
"hamburgerHoverColor": "color",
"overlayColor": "color",
"hamburguerFocusColor": "color",
"hamburgerFocusColor": "color",
"logo": "image",
"logoResponsive": "image",
"hamburguerTextTransform": "fTextTransform",
"hamburgerTextTransform": "fTextTransform",
"underlinedThickness": "bWidth",
"underlinedStyle": "bStyle",
"minHeight": "length",
Expand All @@ -569,11 +562,11 @@
"menuMobileWidth": "length",
"overlayOpacity": "alphaValue",
"overlayZindex": "integer",
"hamburguerFontFamily": "fFamily",
"hamburguerFontStyle": "fStyle",
"hamburguerFontColor": "color",
"hamburguerFontSize": "length",
"hamburguerFontWeight": "fWeight",
"hamburgerFontFamily": "fFamily",
"hamburgerFontStyle": "fStyle",
"hamburgerFontColor": "color",
"hamburgerFontSize": "length",
"hamburgerFontWeight": "fWeight",
"contentColor": "color"
},
"heading": {
Expand Down
2 changes: 1 addition & 1 deletion apps/website/screens/theme-generator/themes/schemas/opinionated.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"accentColor": "color",
"fontColor": "color",
"menuBaseColor": "color",
"hamburguerColor": "color",
"hamburgerColor": "color",
"logo": "image",
"logoResponsive": "image",
"contentColor": "color",
Expand Down
Loading
Loading