Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jan 9, 2025

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description

  • ProgressBar component review (no breaking changes).
  • Wizard component review (no breaking changes).
  • Use the ActionIcon in the Dialog component as the default close action.
  • Review the default value from some components (Wizard, Switch, and Checkbox). The uncontrolled default value is now set by the corresponding defaultValue prop and documented (we were inconsistent).
  • Fixed a typo in naming the hamburger tokens: hamburguerXXXhamburgerXXX.
  • Added comments to the props of both the Alert and the Toast components.
  • Removed aria-label from several places where it was poorly used.
    • Icon. Its aria-hidden property is set to true, and the aria-label will not be read by screen readers.
    • FileItem. Removed, unnecessary, the file item must be identified by the name of the file.
  • Improved accessibility from FileInput. Removed role document (not properly used) from the image preview of a file and now uses the roles list and listitem.

@GomezIvann GomezIvann marked this pull request as ready for review January 10, 2025 12:47
@Mil4n0r Mil4n0r self-requested a review January 13, 2025 11:30
@Mil4n0r Mil4n0r self-assigned this Jan 13, 2025
@Mil4n0r Mil4n0r self-requested a review January 13, 2025 16:27
@Mil4n0r Mil4n0r merged commit 980cbf7 into master Jan 13, 2025
4 checks passed
@Mil4n0r Mil4n0r deleted the gomezivann/several-updates branch January 13, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants