-
Notifications
You must be signed in to change notification settings - Fork 17
Several updates & fixes in Halstack #2134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mil4n0r
requested changes
Jan 13, 2025
apps/website/screens/theme-generator/themes/schemas/advanced.schema.json
Outdated
Show resolved
Hide resolved
Mil4n0r
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
ProgressBarcomponent review (no breaking changes).Wizardcomponent review (no breaking changes).ActionIconin theDialogcomponent as the default close action.Wizard,Switch, andCheckbox). The uncontrolled default value is now set by the correspondingdefaultValueprop and documented (we were inconsistent).hamburguerXXX⇒hamburgerXXX.Alertand theToastcomponents.aria-labelfrom several places where it was poorly used.Icon. Itsaria-hiddenproperty is set totrue, and thearia-labelwill not be read by screen readers.FileItem. Removed, unnecessary, the file item must be identified by the name of the file.FileInput. Removed roledocument(not properly used) from the image preview of a file and now uses the roleslistandlistitem.