-
Notifications
You must be signed in to change notification settings - Fork 17
Enabled strict mode and added required changes to the current code #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
313de04
Added required changes to types in order to enable strict mode
6ee271f
Added remaining required changes for strict mode
91f9abf
Added remaining required changes for strict mode
0350f13
Removed unintentional changes
c3178b3
Merge branch 'master' of github.com:dxc-technology/halstack-react int…
2c6fec9
Fixed problems with tests due to focus lock
05958a5
Restore Breadcrumbs item keys
GomezIvann 7880bd3
Badge component updates
GomezIvann a905943
Added corrections from review
Mil4n0r f6e5b34
Merge branch 'Mil4n0r/strict-mode-true' of github.com:dxc-technology/…
Mil4n0r 0972270
Added more corrections from review
Mil4n0r c710645
Maintained same structure for HalstackContext
Mil4n0r 3e120af
Contextual Menu updates
GomezIvann 332061b
Merge branch 'Mil4n0r/strict-mode-true' of https://github.com/dxc-tec…
GomezIvann 87823c3
Improved getNavigationLinks implementation
Mil4n0r 9d71f78
Merge branch 'Mil4n0r/strict-mode-true' of github.com:dxc-technology/…
Mil4n0r eb47268
Removed unneeded React imports
Mil4n0r 5361bb2
Added fixes for PR review
Mil4n0r 30bab73
Discussed updates
GomezIvann b6ff887
Small change
GomezIvann c1bf883
HalstackContext typing updates
GomezIvann b5f163d
Small updated
GomezIvann 8392956
Optional chaining fixed
GomezIvann 84f34e0
Refactorized some of the stories
Mil4n0r ff667be
Merge branch 'Mil4n0r/strict-mode-true' of github.com:dxc-technology/…
Mil4n0r 3e8ec1c
Updating components
GomezIvann 42e5fdb
Updated test to fix typing errors
GomezIvann b9d5031
Refactorized rest of the stories
Mil4n0r c25d85e
Merge branch 'Mil4n0r/strict-mode-true' of github.com:dxc-technology/…
Mil4n0r 3818b58
Removing undesired optional chaining operators
GomezIvann 40d194d
Removed 'React.' and importing functions directly instead
Mil4n0r 126c02f
Merge branch 'Mil4n0r/strict-mode-true' of github.com:dxc-technology/…
Mil4n0r baaf87f
Changed story name
Mil4n0r 2227183
Added additional fixes for typings after context updates
Mil4n0r 06520b9
Fixing type errors in affected files
GomezIvann c36d9f6
Small fixes
GomezIvann 40d3dd5
Fixed TypeScript problems in stories and tests
Mil4n0r 26f9307
Fixed problem with interaction in DataGrid stories
Mil4n0r 0773f46
Fixed problem with interaction in DataGrid stories
Mil4n0r e1e5fbe
Fixed problem with interaction in DataGrid stories
Mil4n0r 162780a
Fixed problem with interaction in DataGrid stories
Mil4n0r 9ece46e
Merge branch 'master' into Mil4n0r/strict-mode-true
Mil4n0r d266130
Changed var names in tests for better readability
Mil4n0r 6e49d1a
Changed var names in tests for better readability
Mil4n0r 7d3ea1b
Removed no-longer-needed nullish coallescing operators
3dd15f9
Removing Background Color Context
GomezIvann 5547170
Code updates
GomezIvann ca255a5
Includes improvements from strict mode PR review
d8195ad
Merge branch 'Mil4n0r/strict-mode-true' of github.com:dxc-technology/…
527ccc3
Refactorized textarea code
82a6a9c
Small code updates
GomezIvann f8a0b96
Merge branch 'Mil4n0r/strict-mode-true' of https://github.com/dxc-tec…
GomezIvann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -278,7 +278,6 @@ const sections = [ | |
| </DxcTable> | ||
| ), | ||
| }, | ||
| , | ||
| { | ||
| title: "DxcDataGrid.ActionsCell", | ||
| content: ( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.