Enabled strict mode and added required changes to the current code #2126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Mil4n0r/strict-mode-true
GomezIvann
suggested changes
Dec 11, 2024
Collaborator
GomezIvann
left a comment
GomezIvann
left a comment
There was a problem hiding this comment.
This is a partial review! Before continue reviewing this PR Enrique I would like you to avoid changes that are not related to Typescript errors please It is not because I differ with your programming preferences, is a question of how difficult it makes it for me to review these types of scenarios where I don't know if you have made the change out of typescript/lint or personal preference.
I would like to keep this PR as clean and focused as possible on the flag strict: true please!
…halstack-react into Mil4n0r/strict-mode-true
…hnology/halstack-react into Mil4n0r/strict-mode-true
…halstack-react into Mil4n0r/strict-mode-true
GomezIvann
suggested changes
Dec 16, 2024
…halstack-react into Mil4n0r/strict-mode-true
…halstack-react into Mil4n0r/strict-mode-true
GomezIvann
suggested changes
Jan 2, 2025
…halstack-react into Mil4n0r/strict-mode-true
…hnology/halstack-react into Mil4n0r/strict-mode-true
GomezIvann
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Enabled strict mode