Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,30 @@
- Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)

# 2.134.x
* Add setting `dotnet.fileBasedApps.enableAutomaticDiscovery` (PR: [#9096](https://github.com/dotnet/vscode-csharp/pull/9096))
* Update Roslyn to 5.7.0-1.26203.6 (PR: [#9096](https://github.com/dotnet/vscode-csharp/pull/9096))
* File-based apps automatic discovery (PR: [#82863](https://github.com/dotnet/roslyn/pull/82863))
* Fix evaluations inside ref-returning methods (PR: [#83037](https://github.com/dotnet/roslyn/pull/83037))
* Fix with-element indentation in collection expressions on multiple lines (PR: [#83030](https://github.com/dotnet/roslyn/pull/83030))
* Do not crash if URI not parseable and no default handler exists (PR: [#83024](https://github.com/dotnet/roslyn/pull/83024))
* Allow generate method to run on Razor documents (PR: [#83028](https://github.com/dotnet/roslyn/pull/83028))
* Preserve #: file-based app directives during formatting (PR: [#82996](https://github.com/dotnet/roslyn/pull/82996))
* Move inheritance margin logic to a features service (PR: [#83001](https://github.com/dotnet/roslyn/pull/83001))
* Don't format plain blocks as member declaration blocks in top level code (PR: [#82976](https://github.com/dotnet/roslyn/pull/82976))
* Add LSP CallHierarchy support (PR: [#82865](https://github.com/dotnet/roslyn/pull/82865))
* Move CallHierarchy logic to the Features layer (PR: [#82864](https://github.com/dotnet/roslyn/pull/82864))
* Handle misc project having an AdditionalDocument and not a Document (PR: [#82956](https://github.com/dotnet/roslyn/pull/82956))
* Fix structure guideline anchor for initializer expressions with multi-line argument lists (PR: [#82946](https://github.com/dotnet/roslyn/pull/82946))
* Navigate to position instead of span for Go to Implementation (PR: [#82906](https://github.com/dotnet/roslyn/pull/82906))
* Only cache diagnostics for legacy projects (PR: [#82643](https://github.com/dotnet/roslyn/pull/82643))
* Improve classification of file-based app directives (PR: [#82627](https://github.com/dotnet/roslyn/pull/82627))
* Add support for skipping analyzing banned API analysis in generated files (PR: [#82713](https://github.com/dotnet/roslyn/pull/82713))
* Add regex search support to NavigateTo (PR: [#82706](https://github.com/dotnet/roslyn/pull/82706))
* Add completion provider for `#:include` directives (PR: [#82625](https://github.com/dotnet/roslyn/pull/82625))
* Modify SyntaxNode trivia search/walk methods to utilize green node checks (PR: [#82893](https://github.com/dotnet/roslyn/pull/82893))
* Fix handling of added import trivia (PR: [#82788](https://github.com/dotnet/roslyn/pull/82788))
* DeterministicKeyBuilder: deduplicate ParseOptions across SyntaxTrees (PR: [#82895](https://github.com/dotnet/roslyn/pull/82895))
* Fix InvalidCastException in split-if refactoring for top-level statements (PR: [#82807](https://github.com/dotnet/roslyn/pull/82807))

# 2.133.x

Expand Down
10 changes: 9 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"workspace"
],
"defaults": {
"roslyn": "5.6.0-2.26173.1",
"roslyn": "5.7.0-1.26203.6",
"omniSharp": "1.39.14",
"razor": "10.0.0-preview.26179.2",
"razorOmnisharp": "7.0.0-preview.23363.1",
Expand Down Expand Up @@ -1561,6 +1561,14 @@
"tags": [
"preview"
]
},
"dotnet.fileBasedApps.enableAutomaticDiscovery": {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to migrate the other settings to this new prefix? It kinda makes sense, since it's odd the old switches were under a "projects" node which is odd given the entire point of them is they aren't projects. 😄

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes #9136

"type": "boolean",
"default": true,
"description": "%configuration.dotnet.fileBasedApps.enableAutomaticDiscovery%",
"tags": [
"preview"
]
}
}
},
Expand Down
1 change: 1 addition & 0 deletions package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"configuration.dotnet.projects.enableAutomaticRestore": "Enables automatic NuGet restore if the extension detects assets are missing.",
"configuration.dotnet.projects.enableFileBasedPrograms": "Enables the \"file-based programs\" (dotnet run app.cs) experience.",
"configuration.dotnet.projects.enableFileBasedProgramsWhenAmbiguous": "Enables the \"file-based programs\" (dotnet run app.cs) experience in files where the editor is unable to determine with certainty whether the file is a file-based program. Only respected when `dotnet.projects.enableFileBasedPrograms` is `true`.",
"configuration.dotnet.fileBasedApps.enableAutomaticDiscovery": "Enables automatic discovery of C# file-based apps in the workspace.",
"configuration.dotnet.projects.binaryLogPath": "Sets a path where MSBuild binary logs are written to when loading projects, to help diagnose loading errors.",
"configuration.dotnet.server.sourceGeneratorExecution": "Controls when source generators are executed. (Requires extension restart)",
"configuration.dotnet.server.sourceGeneratorExecution.balanced": "Source generators are executed after an explicit user action, including save, build, or the [Rerun source generators](command:csharp.rerunSourceGenerators) command.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ describe(`Go To Implementation Tests`, () => {
expect(implementationList).toHaveLength(2);

expect(implementationList[0].uri.path).toContain('BaseClassImplementation.cs');
expect(implementationList[0].range).toStrictEqual(new vscode.Range(2, 17, 2, 40));
expect(implementationList[0].range).toStrictEqual(new vscode.Range(2, 17, 2, 17));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test changes look correct!


expect(implementationList[1].uri.path).toContain('implementation.cs');
expect(implementationList[1].range).toStrictEqual(new vscode.Range(5, 17, 5, 26));
expect(implementationList[1].range).toStrictEqual(new vscode.Range(5, 17, 5, 17));
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ describe(`Razor References ${testAssetWorkspace.description}`, function () {
expect(definitionLocation.range.start.line).toBe(23);
expect(definitionLocation.range.start.character).toBe(10);
expect(definitionLocation.range.end.line).toBe(23);
expect(definitionLocation.range.end.character).toBe(19);
expect(definitionLocation.range.end.character).toBe(10);
}
);
});
Expand Down
Loading