-
Notifications
You must be signed in to change notification settings - Fork 750
Add setting dotnet.fileBasedApps.enableAutomaticDiscovery
#9096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9673c48
Add setting for file-based apps auto discovery
RikkiGibson 5fbb0fd
rename setting
RikkiGibson 0880853
fix
RikkiGibson 77a9e66
Merge remote-tracking branch 'upstream/main' into fba-discovery-enable
RikkiGibson 482376c
Update Roslyn to 5.7.0-1.26203.6
RikkiGibson f8024d5
Update changelog with PR number
RikkiGibson c26f35e
Update test expectations for Go to Implementation position change
RikkiGibson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,10 +38,10 @@ describe(`Go To Implementation Tests`, () => { | |
| expect(implementationList).toHaveLength(2); | ||
|
|
||
| expect(implementationList[0].uri.path).toContain('BaseClassImplementation.cs'); | ||
| expect(implementationList[0].range).toStrictEqual(new vscode.Range(2, 17, 2, 40)); | ||
| expect(implementationList[0].range).toStrictEqual(new vscode.Range(2, 17, 2, 17)); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test changes look correct! |
||
|
|
||
| expect(implementationList[1].uri.path).toContain('implementation.cs'); | ||
| expect(implementationList[1].range).toStrictEqual(new vscode.Range(5, 17, 5, 26)); | ||
| expect(implementationList[1].range).toStrictEqual(new vscode.Range(5, 17, 5, 17)); | ||
| }); | ||
| }); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to migrate the other settings to this new prefix? It kinda makes sense, since it's odd the old switches were under a "projects" node which is odd given the entire point of them is they aren't projects. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes #9136