Add setting dotnet.fileBasedApps.enableAutomaticDiscovery#9096
Merged
RikkiGibson merged 7 commits intodotnet:mainfrom Apr 7, 2026
Merged
Add setting dotnet.fileBasedApps.enableAutomaticDiscovery#9096RikkiGibson merged 7 commits intodotnet:mainfrom
dotnet.fileBasedApps.enableAutomaticDiscovery#9096RikkiGibson merged 7 commits intodotnet:mainfrom
Conversation
RikkiGibson
changed the title
dotnet.fileBasedApps.enableAutomaticDiscoverydotnet.fileBasedApps.enableAutomaticDiscovery
2 tasks
dibarbet
approved these changes
Apr 6, 2026
The Roslyn update (5.7.0-1.26203.6) includes PR dotnet/roslyn#82906 which changes Go to Implementation to navigate to a position instead of a span. This updates the test expectations to match the new behavior where ranges are positions (start == end) instead of spans. Fixes test failures in: - gotoImplementation.integration.test.ts - reference.integration.test.ts
Member
Author
|
@akhera99 quick check--do changes in commit c26f35e match your expectations given dotnet/roslyn#82906? |
jasonmalinowski
approved these changes
Apr 6, 2026
| "preview" | ||
| ] | ||
| }, | ||
| "dotnet.fileBasedApps.enableAutomaticDiscovery": { |
Member
There was a problem hiding this comment.
Is the plan to migrate the other settings to this new prefix? It kinda makes sense, since it's odd the old switches were under a "projects" node which is odd given the entire point of them is they aren't projects. 😄
akhera99
approved these changes
Apr 6, 2026
|
|
||
| expect(implementationList[0].uri.path).toContain('BaseClassImplementation.cs'); | ||
| expect(implementationList[0].range).toStrictEqual(new vscode.Range(2, 17, 2, 40)); | ||
| expect(implementationList[0].range).toStrictEqual(new vscode.Range(2, 17, 2, 17)); |
JoeRobich
approved these changes
Apr 6, 2026
Member
Author
|
@dibarbet when this flows to release branch we just want to make sure to go into the setting definition and flip default to false. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates the Roslyn version to include the automatic discovery feature.