-
Notifications
You must be signed in to change notification settings - Fork 21
Match tests folder structure to src folder structure
#206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
|
@sbillinge ready for review, just quick cosmetics fix. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 8 8
Lines 342 342
=======================================
Hits 330 330
Misses 12 12
|
|
What is the reason for doing this? |
Since test files are all located under |
Yes, I understand what you are trying to do. I am wondering why. I would think just having the tests flat is easier to manage and maintain. They don't have to replicate any package structure. |
|
if we worry about name clashes (there shouldn't be too many) it should be easy to disambiguate. If we thought it helped we could use the full package name in the file name if we liked too, like |
I had thought it was standard to mirror the src structure, but now, after thinking and searching more, I don't have a clear reason. Also, adopting a flat structure doesn’t deviate from the fact that tests aren't written for the code but rather for flexibility, and we write tests for intended behavior, not for the code itself. |
Closes #205 - match
testsandsrcfolder structures.