Skip to content

fix(decoredirect): log reason when isDNSReady returns false #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igoramf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(decoredirect): log reason when isDNSReady returns false #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/controller/decoredirect_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,20 +262,25 @@ func isCertFailed(cert *cmv1.Certificate) bool {
// 2. No AAAA record falls within any BlockedIPv6CIDRs range, which would cause
// Let's Encrypt's IPv6 validation to reach the wrong server and fail the challenge.
func (r *DecoRedirectReconciler) isDNSReady(ctx context.Context, domain string) bool {
log := logf.FromContext(ctx)

httpClient := &http.Client{
CheckRedirect: func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse },
Timeout: 5 * time.Second,
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, "http://"+domain+"/", nil)
if err != nil {
log.Error(err, "isDNSReady: failed to build HTTP request", "domain", domain)
return false
}
resp, err := httpClient.Do(req)
if err != nil {
log.Error(err, "isDNSReady: HTTP check failed", "domain", domain)
return false
}
_ = resp.Body.Close()
if resp.Header.Get("X-Redirect-By") != "deco" {
if h := resp.Header.Get("X-Redirect-By"); h != "deco" {
log.Info("isDNSReady: X-Redirect-By header mismatch", "domain", domain, "got", h)
return false
}

Expand All @@ -285,6 +290,7 @@ func (r *DecoRedirectReconciler) isDNSReady(ctx context.Context, domain string)

addrs, err := net.DefaultResolver.LookupIPAddr(ctx, domain)
if err != nil {
log.Error(err, "isDNSReady: DNS lookup failed", "domain", domain)
return false
}
for _, a := range addrs {
Expand All @@ -294,6 +300,7 @@ func (r *DecoRedirectReconciler) isDNSReady(ctx context.Context, domain string)
}
for _, blocked := range r.BlockedIPv6CIDRs {
if blocked.Contains(ip) {
log.Info("isDNSReady: blocked IPv6 found", "domain", domain, "ip", ip, "cidr", blocked)
return false
}
}
Expand Down
Loading