fix(decoredirect): log reason when isDNSReady returns false#21
Open
igoramf wants to merge 1 commit into
Open
Conversation
Previously isDNSReady failed silently, making it impossible to diagnose whether the HTTP check, the X-Redirect-By header, or the AAAA lookup was the culprit — as seen when a stuck operator pod required a restart. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isDNSReadyfalhava silenciosamente, sem logar o motivo, tornando impossível diagnosticar se o problema era no HTTP check, no headerX-Redirect-By, ou no DNS lookup de AAAAmeiasola.com.brpreso emCertificateReady=False— o operator logava "DNS not ready yet" mas sem indicar o porquê, exigindo um restart para resolverTest plan
isDNSReadymostram o motivo quando um domínio falha a checagem🤖 Generated with Claude Code
Summary by cubic
Add detailed logging to
isDNSReadyso we can see why DNS readiness fails instead of failing silently. This helps diagnose stuck certificates by showing whether the HTTP check,X-Redirect-Byheader, DNS lookup, or blocked IPv6 is the cause.X-Redirect-Byvalues.Written for commit 316040f. Summary will update on new commits.