Add RemappedRandomAccessVectorValues to fix BuildScoreProvider::randomAccessScoreProvider#555
Merged
marianotepper merged 3 commits intomainfrom Oct 22, 2025
Merged
Conversation
…mAccessScoreProvider
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
marianotepper
approved these changes
Oct 22, 2025
Contributor
marianotepper
left a comment
There was a problem hiding this comment.
Looks like an improvement over the alternative #554
Contributor
|
@sam-herman please take a look at this PR. As it is an improvement over #536 and over the alternative #554 |
Contributor
Thanks for the heads up! LGTM as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to show an alternative to #554. The main idea is that we already have a mapping class, and if the caller wants to remap values, they can do it on their own. The primary benefit of this change is that is backwards compatible, while #554 is not.