Fix BuildScoreProvider::randomAccessScoreProvider bug#554
Closed
michaeljmarshall wants to merge 1 commit intomainfrom
Closed
Fix BuildScoreProvider::randomAccessScoreProvider bug#554michaeljmarshall wants to merge 1 commit intomainfrom
michaeljmarshall wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
Contributor
|
@sam-herman please take a look at this PR. As it is an improvement over #536 |
Contributor
|
IMO, #555 is the preferred fix for this, so I think we should not merge this PR and go with the other one instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comment: https://github.com/datastax/jvector/pull/536/files#r2453090826
In #536, there was an addition that prevented concurrent addition of vectors to the
RandomAccessVectorValuesobject. This behavior has been allowed in downstream projects, so I propose we return to it. Further, I replaced an identity map array with a simpleOrdinalMapperidentity function. It might be confusing to use theOrdinalMapper, but in reading it's javadoc, I think it applies here.The added test fails without this change.