Skip to content

Updated the PyArrow concatenation of tables to use promote_options as default #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jprakash-db merged 1 commit into from
Mar 10, 2026
Merged

Updated the PyArrow concatenation of tables to use promote_options as default #751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/databricks/sql/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ def concat_table_chunks(
result_table[j].extend(table_chunks[i].column_table[j])
return ColumnTable(result_table, table_chunks[0].column_names)
else:
return pyarrow.concat_tables(table_chunks)
return pyarrow.concat_tables(table_chunks, promote_options="default")


def serialize_query_tags(
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_cloud_fetch_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def test_next_n_rows_more_than_one_table(self, mock_create_next_table):
assert (
result
== pyarrow.concat_tables(
[self.make_arrow_table(), self.make_arrow_table()]
[self.make_arrow_table(), self.make_arrow_table()],promote_options="default"
)[:7]
)

Expand Down Expand Up @@ -266,7 +266,7 @@ def test_remaining_rows_multiple_tables_fully_returned(
assert (
result
== pyarrow.concat_tables(
[self.make_arrow_table(), self.make_arrow_table()]
[self.make_arrow_table(), self.make_arrow_table()], promote_options="default"
)[3:]
)

Expand Down
Loading