Skip to content

Updated the PyArrow concatenation of tables to use promote_options as default#751

Merged
jprakash-db merged 1 commit intomainfrom
jprakash-db/updated-pyarrow-concat
Mar 10, 2026
Merged

Updated the PyArrow concatenation of tables to use promote_options as default#751
jprakash-db merged 1 commit intomainfrom
jprakash-db/updated-pyarrow-concat

Conversation

@jprakash-db
Copy link
Contributor

@jprakash-db jprakash-db commented Mar 10, 2026

Updated the PyArrow concatenation of tables to use promote_options as default

Resolves this issue - #418

Copilot AI review requested due to automatic review settings March 10, 2026 10:06
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes PyArrow table concatenation behavior explicit by passing promote_options="default" to pyarrow.concat_tables, helping keep concatenation semantics stable across PyArrow versions in the connector’s Arrow result handling.

Changes:

  • Update concat_table_chunks() to call pyarrow.concat_tables(..., promote_options="default").
  • Update relevant unit tests to assert against the new explicit concat_tables behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/databricks/sql/utils.py Explicitly sets promote_options="default" when concatenating PyArrow table chunks.
tests/unit/test_cloud_fetch_queue.py Updates concat_tables-based expectations to include promote_options="default".

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jprakash-db jprakash-db merged commit 36fb376 into main Mar 10, 2026
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants