Updated the PyArrow concatenation of tables to use promote_options as default#751
Merged
jprakash-db merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
gopalldb
approved these changes
Mar 10, 2026
There was a problem hiding this comment.
Pull request overview
This PR makes PyArrow table concatenation behavior explicit by passing promote_options="default" to pyarrow.concat_tables, helping keep concatenation semantics stable across PyArrow versions in the connector’s Arrow result handling.
Changes:
- Update
concat_table_chunks()to callpyarrow.concat_tables(..., promote_options="default"). - Update relevant unit tests to assert against the new explicit
concat_tablesbehavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/databricks/sql/utils.py |
Explicitly sets promote_options="default" when concatenating PyArrow table chunks. |
tests/unit/test_cloud_fetch_queue.py |
Updates concat_tables-based expectations to include promote_options="default". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the PyArrow concatenation of tables to use promote_options as default
Resolves this issue - #418