Skip to content

Conversation

@vinniefalco
Copy link
Member

@vinniefalco vinniefalco commented Feb 1, 2026

Summary by CodeRabbit

  • Documentation
    • Added comprehensive style guide for documentation with writing principles, tone guidelines, and formatting rules to ensure consistency.
    • Introduced documentation rebuild guide outlining structure, generation processes, and conventions for maintaining quality documentation.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Feb 1, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (39)
  • doc/modules/ROOT/nav.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/buffers/algorithms.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/buffers/dynamic.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/buffers/overview.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/buffers/sequences.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/buffers/system-io.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/buffers/types.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/concurrency/advanced.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/concurrency/foundations.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/concurrency/patterns.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/concurrency/synchronization.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/coroutines/allocators.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/coroutines/cancellation.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/coroutines/composition.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/coroutines/executors.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/coroutines/io-awaitable.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/coroutines/launching.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/coroutines/tasks.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/cpp20-coroutines/advanced.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/cpp20-coroutines/foundations.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/cpp20-coroutines/machinery.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/cpp20-coroutines/syntax.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/examples/buffer-composition.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/examples/custom-dynamic-buffer.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/examples/echo-server-corosio.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/examples/hello-task.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/examples/mock-stream-testing.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/examples/parallel-fetch.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/examples/producer-consumer.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/examples/stream-pipeline.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/examples/timeout-cancellation.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/examples/type-erased-echo.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/index.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/streams/algorithms.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/streams/buffer-concepts.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/streams/isolation.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/streams/overview.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/streams/sources-sinks.adoc is excluded by !**/doc/**
  • doc/modules/ROOT/pages/streams/streams.adoc is excluded by !**/doc/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
📝 Walkthrough

Walkthrough

Two new documentation guide files establish standards for Capy project documentation. The first defines the rebuild process, structure, and style conventions. The second prescribes writing principles, tone, formatting rules, and workflow guidance for documentation creation.

Changes

Cohort / File(s) Summary
Documentation Guidelines
.cursor/commands/doc-rebuild.md, .cursor/rules/writing-guide.mdc
Establishes documentation rebuild procedures, structural requirements, style conventions, and authoring standards including tone, formatting, and content rules.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A hop through the docs, we've laid out the way,
With style guides and phases to brighten the day,
Each section and tone now crystal and clear,
Capy's grand narrative shall echo for all to hear! 📚✨

🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Regenerate Documentation' is vague and generic, lacking specificity about what documentation changes are being made or what the actual content additions entail. Consider a more descriptive title such as 'Add documentation rebuild guide and writing style guide' to clearly communicate the main changes being introduced.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.cursor/commands/doc-rebuild.md:
- Around line 16-35: Remove the extra leading indentation on the nested bullet
lines inside the verbatim sections so list markers are flush-left (fix the lists
under the headings "2. **What This Library Does**", "3. **What This Library Does
Not Do**", and "4. **Target Audience**"); edit each verbatim bullet block in
.cursor/commands/doc-rebuild.md to delete the extra spaces before "-" or "*" so
markdownlint MD007 is satisfied, and apply the same adjustment to any other
similar verbatim list blocks in the file.

Comment on lines +16 to +35
2. **What This Library Does** (verbatim):
- Lazy coroutine tasks — `task<T>` with forward-propagating stop tokens and automatic cancellation
- Buffer sequences — taken straight from Asio and improved
- Stream concepts — `ReadStream`, `WriteStream`, `ReadSource`, `WriteSink`, `BufferSource`, `BufferSink`
- Type-erased streams — `any_stream`, `any_read_stream`, `any_write_stream` for fast compilation
- Concurrency facilities — executors, strands, thread pools, `when_all`, `when_any`
- Test utilities — mock streams, mock sources/sinks, error injection
3. **What This Library Does Not Do** (verbatim):
- Networking — no sockets, acceptors, or DNS; that's what Corosio provides
- Protocols — no HTTP, WebSocket, or TLS; see the Http and Beast2 libraries
- Platform event loops — no io_uring, IOCP, epoll, or kqueue; Capy is the layer above
- Callbacks or futures — coroutine-only means no other continuation styles
- Sender/receiver — Capy uses the IoAwaitable protocol, not `std::execution`
4. **Target Audience** (verbatim):
- Users of Corosio — portable coroutine networking
- Users of Http — sans-I/O HTTP/1.1 clients and servers
- Users of Websocket — sans-I/O WebSocket
- Users of Beast2 — high-level HTTP/WebSocket servers
- Users of Burl — high-level HTTP client
All of these are built on Capy. Understanding its concepts—tasks, buffer sequences, streams, executors—unlocks the full power of the stack.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix unordered-list indentation to satisfy MD007.

The nested bullets in these verbatim sections are indented when they should be flush-left, triggering markdownlint MD007. Please remove the extra indentation for these lists and apply the same adjustment to the similar verbatim bullet blocks throughout the file.

🧹 Suggested fix (apply consistently to all similar blocks)
-  - Lazy coroutine tasks — `task<T>` with forward-propagating stop tokens and automatic cancellation
-  - Buffer sequences — taken straight from Asio and improved
-  - Stream concepts — `ReadStream`, `WriteStream`, `ReadSource`, `WriteSink`, `BufferSource`, `BufferSink`
-  - Type-erased streams — `any_stream`, `any_read_stream`, `any_write_stream` for fast compilation
-  - Concurrency facilities — executors, strands, thread pools, `when_all`, `when_any`
-  - Test utilities — mock streams, mock sources/sinks, error injection
+ - Lazy coroutine tasks — `task<T>` with forward-propagating stop tokens and automatic cancellation
+ - Buffer sequences — taken straight from Asio and improved
+ - Stream concepts — `ReadStream`, `WriteStream`, `ReadSource`, `WriteSink`, `BufferSource`, `BufferSink`
+ - Type-erased streams — `any_stream`, `any_read_stream`, `any_write_stream` for fast compilation
+ - Concurrency facilities — executors, strands, thread pools, `when_all`, `when_any`
+ - Test utilities — mock streams, mock sources/sinks, error injection
🧰 Tools
🪛 markdownlint-cli2 (0.20.0)

[warning] 17-17: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 18-18: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 19-19: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 20-20: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 21-21: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 22-22: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 24-24: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 25-25: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 26-26: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 27-27: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 28-28: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 30-30: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 31-31: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 32-32: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 33-33: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


[warning] 34-34: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)

🤖 Prompt for AI Agents
In @.cursor/commands/doc-rebuild.md around lines 16 - 35, Remove the extra
leading indentation on the nested bullet lines inside the verbatim sections so
list markers are flush-left (fix the lists under the headings "2. **What This
Library Does**", "3. **What This Library Does Not Do**", and "4. **Target
Audience**"); edit each verbatim bullet block in .cursor/commands/doc-rebuild.md
to delete the extra spaces before "-" or "*" so markdownlint MD007 is satisfied,
and apply the same adjustment to any other similar verbatim list blocks in the
file.

@cppalliance-bot
Copy link

cppalliance-bot commented Feb 1, 2026

An automated preview of the documentation is available at https://120.capy.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-02-01 07:03:05 UTC

@cppalliance-bot
Copy link

cppalliance-bot commented Feb 1, 2026

GCOVR code coverage report https://120.capy.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://120.capy.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://120.capy.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-02-01 07:07:11 UTC

@vinniefalco vinniefalco merged commit 443f213 into cppalliance:develop Feb 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants