-
Notifications
You must be signed in to change notification settings - Fork 16
Refactor documentation generation framework #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe documentation rebuild file was restructured, shifting from a prescriptive multi-part tutorial and style-guide-driven approach to a streamlined, beginner-focused architecture. The Style Guide and Agent Guide Reference sections were removed entirely, with tutorial sections reorganized under a new "Tutorials For Beginners" label. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.cursor/commands/doc-rebuild.md:
- Around line 18-20: The three indented bullets ("Buffer sequences — taken
straight from Boost.Asio and improved", "Stream concepts — _ReadStream_,
_WriteStream_, _ReadSource_, _WriteSink_, _BufferSource_, _BufferSink_", and
"Type-erased streams — `any_stream`, `any_read_stream`, `any_write_stream`, fast
compilation") are incorrectly indented; remove the leading two-space indentation
so they become top-level bullets under the "What This Library Does" section (or
alternatively, if you intend them as nested under item 2, convert the parent
item into an explicit list item first), ensuring the bullets follow standard
Markdown list indentation rules.
🧹 Nitpick comments (1)
.cursor/commands/doc-rebuild.md (1)
5-7: Consider separating header levels from list numbering.The pattern
## 1. Introduction Pagemixes markdown header syntax with numbered list formatting. While functional, this is non-standard. Consider either:
- Using pure headers:
## Introduction Page- Or using a numbered list under a header rather than embedding numbers in header text
This would improve consistency with typical markdown conventions.
.cursor/commands/doc-rebuild.md
Outdated
| - Buffer sequences — taken straight from Boost.Asio and improved | ||
| - Stream concepts — _ReadStream_, _WriteStream_, _ReadSource_, _WriteSink_, _BufferSource_, _BufferSink_ | ||
| - Type-erased streams — `any_stream`, `any_read_stream`, `any_write_stream`, fast compilation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix list indentation to match markdown conventions.
The static analysis tool flags these lines for incorrect indentation. The bullets are indented by 2 spaces, but the parent item "What This Library Does" is not formatted as a list item—it's in the numbered requirement prose above.
Two options to fix:
- If these should be nested under item 2, format item 2 as an explicit list item first
- If these should be standalone, remove the indentation
🔧 Proposed fix: Remove indentation for standalone bullets
2. **What This Library Does** (verbatim):
- - Lazy coroutine tasks — `task<T>` with forward-propagating stop tokens and automatic cancellation
- - Buffer sequences — taken straight from Boost.Asio and improved
- - Stream concepts — _ReadStream_, _WriteStream_, _ReadSource_, _WriteSink_, _BufferSource_, _BufferSink_
- - Type-erased streams — `any_stream`, `any_read_stream`, `any_write_stream`, fast compilation
+- Lazy coroutine tasks — `task<T>` with forward-propagating stop tokens and automatic cancellation
+- Buffer sequences — taken straight from Boost.Asio and improved
+- Stream concepts — _ReadStream_, _WriteStream_, _ReadSource_, _WriteSink_, _BufferSource_, _BufferSink_
+- Type-erased streams — `any_stream`, `any_read_stream`, `any_write_stream`, fast compilation🧰 Tools
🪛 markdownlint-cli2 (0.20.0)
[warning] 18-18: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
[warning] 19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
[warning] 20-20: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🤖 Prompt for AI Agents
In @.cursor/commands/doc-rebuild.md around lines 18 - 20, The three indented
bullets ("Buffer sequences — taken straight from Boost.Asio and improved",
"Stream concepts — _ReadStream_, _WriteStream_, _ReadSource_, _WriteSink_,
_BufferSource_, _BufferSink_", and "Type-erased streams — `any_stream`,
`any_read_stream`, `any_write_stream`, fast compilation") are incorrectly
indented; remove the leading two-space indentation so they become top-level
bullets under the "What This Library Does" section (or alternatively, if you
intend them as nested under item 2, convert the parent item into an explicit
list item first), ensuring the bullets follow standard Markdown list indentation
rules.
|
An automated preview of the documentation is available at https://122.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-02-02 04:58:22 UTC |
|
GCOVR code coverage report https://122.capy.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-02-02 05:05:17 UTC |
Summary by CodeRabbit