Skip to content

fix: validate unicode in model apikey or headers #10380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RomneyDa merged 2 commits into from
Feb 11, 2026
+23 −0
Merged

fix: validate unicode in model apikey or headers #10380

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccd9d15
fix: validate unicode in model apikey or headers
uinstinct Feb 10, 2026
8160711
Update packages/config-yaml/src/validation.ts
uinstinct Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/config-yaml/src/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ export interface ConfigResult<T> {
configLoadInterrupted: boolean;
}

function containsUnicode(str: string): boolean {
return /[^\x00-\x7F]/.test(str);
}

export function validateConfigYaml(
config: ConfigYaml,
): ConfigValidationError[] {
Expand All @@ -32,6 +36,25 @@ export function validateConfigYaml(
if ("uses" in model) {
return;
}

// request headers to the llm api should not contain unicode characters
if (model.apiKey && containsUnicode(model.apiKey)) {
errors.push({
fatal: true,
message: `Model "${model.name}" has an API key containing unicode characters. API keys should only contain ASCII characters.`,
});
}

if (model.requestOptions?.headers) {
for (const [key, value] of Object.entries(model.requestOptions.headers)) {
if (containsUnicode(key) || containsUnicode(value)) {
errors.push({
fatal: true,
message: `Model "${model.name}" has a request header "${key}" containing unicode characters. Request headers should only contain ASCII characters.`,
});
}
}
}
// Max tokens not too close to context length
if (
model.defaultCompletionOptions?.contextLength &&
Expand Down
Loading