Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Feb 10, 2026

Description

model's api key or any of the request headers should not contain unicode characters

closes #9910
resolves CON-5307

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

image

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Add validation to block unicode characters in model API keys and request headers in config-yaml. This prevents invalid auth/headers from reaching LLM APIs and fulfills CON-5307 and issue #9910.

  • Bug Fixes
    • Check model.apiKey and requestOptions.headers (names and values) for non-ASCII; raise fatal errors with clear messages.
    • Enforce ASCII-only keys and header values to match HTTP/LLM API requirements.

Written for commit 8160711. Summary will update on new commits.

@uinstinct uinstinct requested a review from a team as a code owner February 10, 2026 06:50
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team February 10, 2026 06:50
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 10, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/config-yaml/src/validation.ts">

<violation number="1" location="packages/config-yaml/src/validation.ts:50">
P2: Header unicode validation only checks values, not header names. HTTP header field-names must be ASCII tokens; unicode header keys will pass validation and can still fail in downstream HTTP clients.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Error: Gemini 2.0 Flash - Unknown error

1 participant