Open
Conversation
guilhem-sante
added
server
guilhem-sante
force-pushed
the
51-extend-market-api-server-configuration
branch
3 times, most recently
from
6222655 to
51c3dc7
Compare
guilhem-sante
force-pushed
the
51-extend-market-api-server-configuration
branch
3 times, most recently
from
d3bfc0d to
ee8fd40
Compare
Extended the configuration of the application to make the server host, port, and tracked symbol configurable. Environment variables can now be overridden from command line arguments. Gave FINWAR_MARKET_ prefix to all environment variables and added a configuration section to the server README.md. Added an /health route to check server status. Closes #45 Closes #49 Closes #51 BREAKING CHANGE: All environment variables have now the FINWAR_MARKET_ prefix. The DATABASE_URL variable have been splitted into DB_USER, DB_PASSWORD, DB_HOST, DB_PORT, and DB_NAME.
guilhem-sante
force-pushed
the
51-extend-market-api-server-configuration
branch
from
ee8fd40 to
c5aea3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended the configuration of the application to make the server host, port, and tracked symbol configurable.
Environment variables can now be overridden from command line arguments.
Gave FINWAR_MARKET_ prefix to all environment variables and added a configuration section to the server README.md.
Added an /health route to check server status.
Closes #45
Closes #49
Closes #51
BREAKING CHANGE: All environment variables have now the FINWAR_MARKET_ prefix. The DATABASE_URL variable have been splitted into DB_USER, DB_PASSWORD, DB_HOST, DB_PORT, and DB_NAME.