Closed
Conversation
guilhem-sante
added
enhancement
dfayd0
requested changes
Nov 14, 2025
Added FINWAR_MARKET_ADDR, FINWAR_MARKET_PORT, FINWAR_MARKET_TARGET_TICKER to the environment variables to configure the market API server. Gave FINWAR_MARKET_ prefix to all environment variables and added a configuration section to the server README.md. Also renamed TICK_INTERVAL_SECONDS into FINWAR_MARKET_TICK_RATE and reduced the minimal tick rate possible from 1 minute to 1 second. Closes #49 BREAKING CHANGE: TICK_INTERVAL_SECONDS and DATABASE_URL have been renamed FINWAR_MARKET_TICK_RATE and FINWAR_MARKET_DATABASE_URL.
guilhem-sante
force-pushed
the
49-make-market-api-target-ticker-symbol-configurable
branch
from
fcb22bc to
b6b2321
Compare
Member
Author
|
Merged this branch on branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added FINWAR_MARKET_ADDR, FINWAR_MARKET_PORT, FINWAR_MARKET_TARGET_TICKER to the environment variables to configure the market API server.
Gave FINWAR_MARKET_ prefix to all environment variables and added a configuration section to the server README.md.
Also renamed TICK_INTERVAL_SECONDS into FINWAR_MARKET_TICK_RATE and reduced the minimal tick rate possible from 1 minute to 1 second.
Closes #49
BREAKING CHANGE: TICK_INTERVAL_SECONDS and DATABASE_URL have been renamed FINWAR_MARKET_TICK_RATE and FINWAR_MARKET_DATABASE_URL.