feat: add account number to the identity claims

[mfrancisc]

generated from codeready-toolchain/api#487

Summary by CodeRabbit

• New Features
  • Added support for an “account number” identity claim in UserSignup, enabling capture and storage of the account_number associated with a user.
  • The new optional string field appears alongside existing identity claims; no existing fields or requirements were changed.
  • Improves flexibility for organizations that rely on account-based identification without impacting current workflows.

[coderabbitai]

Walkthrough

Adds a new string field accountNumber to the UserSignup CRD OpenAPI v3 schema under spec.identityClaims.properties, described as the value of the 'account_number' claim. No other fields or constraints were changed.

Changes

Cohort / File(s)	Summary
UserSignup CRD config/crd/bases/toolchain.dev.openshift.com_usersignups.yaml	Add spec.identityClaims.properties.accountNumber (type: string; description: "AccountNumber contains the value of the 'account_number' claim"). No other schema modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A hare taps keys with whisker’d grace,
“New claim hops in to take its place! 🪪”
AccountNumber joins the crew,
A tidy field, crisp and new—
Burrow logs now trace the race.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe8a288 and 25dd23e.

📒 Files selected for processing (1)

• config/crd/bases/toolchain.dev.openshift.com_usersignups.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Test with Coverage
• GitHub Check: GolangCI Lint
• GitHub Check: Build & push operator bundles for e2e tests

🔇 Additional comments (1)

config/crd/bases/toolchain.dev.openshift.com_usersignups.yaml (1)

94-97: Verify IdentityClaims API type and kubebuilder tags

• I couldn’t find a type IdentityClaims or AccountNumber field in the Go sources—please confirm that the AccountNumber field exists on the IdentityClaims struct with appropriate // +kubebuilder:validation tags and re-generate the CRD via controller-gen rather than hand-editing.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.99%. Comparing base (fe8a288) to head (4972050).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1200   +/-   ##
=======================================
  Coverage   70.99%   70.99%           
=======================================
  Files          82       82           
  Lines        8022     8022           
=======================================
  Hits         5695     5695           
  Misses       2120     2120           
  Partials      207      207           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.