-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add account number to the identity claims #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add account number to the identity claims #487
Conversation
WalkthroughAdded a new optional string field AccountNumber to IdentityClaimsEmbedded, updated the generated OpenAPI schema to include accountNumber, and refreshed API reference documentation formatting to mention the new field. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
api/v1alpha1/docs/apiref.adoc (2)
2104-2104: Fix typo: “a ccess” → “access”Minor doc typo.
-| *`registrationServiceURL`* __string__ | RegistrationServiceURL is the URL used to a ccess the registration service + | | +| *`registrationServiceURL`* __string__ | RegistrationServiceURL is the URL used to access the registration service + | |
772-772: Verified codegen tags; apply doc tweak to clarify optionality-| *`accountNumber`* __string__ | AccountNumber contains the value of the 'account_number' claim + | | +| *`accountNumber`* __string__ | AccountNumber contains the value of the 'account_number' claim (optional; set only when present in the IdP token) + | |
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
api/v1alpha1/docs/apiref.adoc(25 hunks)api/v1alpha1/usersignup_types.go(1 hunks)api/v1alpha1/zz_generated.openapi.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Verify Dependencies
🔇 Additional comments (4)
api/v1alpha1/usersignup_types.go (2)
209-212: AccountNumber field addition looks correctOptional string with proper json tag and doc; consistent with surrounding claims.
209-212: Confirm propagation/usage expectationsIf this claim also needs to flow into MUR/UserAccount, consider adding it to PropagatedClaims; if it's only for analytics, current scope is fine. Also confirm registration-service/host-operator changes read and populate this new field from the IdP claim
account_number.api/v1alpha1/zz_generated.openapi.go (1)
1034-1040: OpenAPI schema updated appropriatelyNew optional property
accountNumberwith clear description; required set unchanged. Regenerated file aligns with the Go struct.api/v1alpha1/docs/apiref.adoc (1)
183-183: AsciiDoc escaping for XPreserveUnknownFields braces: LGTMThe added backslash avoids attribute substitution; formatting-only and correct.
Also applies to: 823-823, 939-939, 1067-1067, 1212-1212, 1389-1389, 1556-1556, 1723-1723, 1961-1961, 2383-2383, 2698-2698, 2804-2804, 2926-2926, 3098-3098, 3147-3147, 3400-3400, 3543-3543, 3685-3685, 3805-3805, 4067-4067



Description
When present we want to send the account number to segment and amplitude as well.
See: https://redhat-internal.slack.com/archives/CHK0J6HT6/p1756885453252769?thread_ts=1756302863.754179&cid=CHK0J6HT6
Jira: https://issues.redhat.com/browse/SANDBOX-1394
Checks
Did you run
make generatetarget? yesDid
make generatechange anything in other projects (host-operatorr)? yesIn case of new CRD, did you the following? N/A
In case other projects are changed, please provides PR links.
Summary by CodeRabbit
New Features
Documentation