Skip to content

Fix GitHub search_issues error handling #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
codegen-sh wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Fix GitHub search_issues error handling #941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
496a349
Fix GitHub search_issues error handling
codegen-sh[bot] Mar 22, 2025
03b05c6
Automated pre-commit update
codegen-sh[bot] Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/codegen/extensions/tools/github/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,18 @@

# Search using PyGitHub's search_issues (which searches both issues and PRs)
results = []
for item in repo.search_issues(query)[:max_results]:
search_results = repo.search_issues(query)

# Handle the case when no results are found
if search_results.totalCount == 0:

Check failure on line 55 in src/codegen/extensions/tools/github/search.py

View workflow job for this annotation

GitHub Actions / mypy 

error: "list[Issue]" has no attribute "totalCount"  [attr-defined]
return SearchResultObservation(
status="success",
query=query,
results=[],
)

# Process the results
for item in search_results[:max_results]:
result = {
"title": item.title,
"number": item.number,
Expand Down
Loading