Fix GitHub search_issues error handling#941
Draft
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the error handling in the
github_search_issuesfunction. Previously, when a search query returned no results, the function would try to access elements in an empty list, resulting in a "list index out of range" error.Changes
search_results.totalCountbefore attempting to iterate through resultsTesting
The fix ensures that when a search query returns no results, the function will return a proper success response with an empty results list instead of throwing an error.
Fixes Linear issue CG-13551.