Skip to content

Conversation

@ZhouXing19
Copy link
Collaborator

Fixes #161674

We saw a nil pointer error with pausable portal, so adding a nil check gate here.

Release note: None

Fixes cockroachdb#161674

We saw a nil pointer error with pausable portal, so adding a nil check
gate here.

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Jan 28, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ZhouXing19 ZhouXing19 added the backport-all Flags PRs that need to be backported to all supported release branches label Jan 28, 2026
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yuzefovich reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball).

@ZhouXing19
Copy link
Collaborator Author

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Jan 28, 2026

@craig craig bot merged commit e00159f into cockroachdb:master Jan 28, 2026
26 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Jan 28, 2026

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

error creating merge commit from ae862df to blathers/backport-release-24.3-161908: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-24.3 failed. See errors above.


💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

error creating merge commit from ae862df to blathers/backport-release-25.2-161908: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-25.2 failed. See errors above.


💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

error creating merge commit from ae862df to blathers/backport-release-25.3-161908: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-25.3 failed. See errors above.


💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all Flags PRs that need to be backported to all supported release branches backport-failed target-release-26.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: v25.4.1: nil pointer when cleaning up the pausable portal

3 participants