release-25.4: sql: add nil check for extendedEvalContext.Placeholders#161911
release-25.4: sql: add nil check for extendedEvalContext.Placeholders#161911yuzefovich merged 1 commit intorelease-25.4from
Conversation
Fixes #161674 We saw a nil pointer error with pausable portal, so adding a nil check gate here. Release note: None
050fbdd to
512864d
Compare
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
❌ PR #161911 does not comply with backport policy Confidence: medium 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Reminder: it has been 2 weeks please merge or close your backport! |
yuzefovich
left a comment
There was a problem hiding this comment.
@yuzefovich reviewed 1 file and all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball).
|
This is fine to backport, but you need a release justification. |
Backport 1/1 commits from #161908 on behalf of @ZhouXing19.
Fixes #161674
We saw a nil pointer error with pausable portal, so adding a nil check gate here.
Release note: None
Release justification: prevent a nil pointer crash in an edge case.