Skip to content

release-25.4: sql: add nil check for extendedEvalContext.Placeholders#161911

Merged
yuzefovich merged 1 commit intorelease-25.4from
blathers/backport-release-25.4-161908
Feb 14, 2026
Merged

release-25.4: sql: add nil check for extendedEvalContext.Placeholders#161911
yuzefovich merged 1 commit intorelease-25.4from
blathers/backport-release-25.4-161908

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl Bot commented Jan 28, 2026

Backport 1/1 commits from #161908 on behalf of @ZhouXing19.


Fixes #161674

We saw a nil pointer error with pausable portal, so adding a nil check gate here.

Release note: None


Release justification: prevent a nil pointer crash in an edge case.

Fixes #161674

We saw a nil pointer error with pausable portal, so adding a nil check
gate here.

Release note: None
@blathers-crl blathers-crl Bot force-pushed the blathers/backport-release-25.4-161908 branch from 050fbdd to 512864d Compare January 28, 2026 04:29
@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 28, 2026
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl Bot commented Jan 28, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-sql-queries SQL Queries Team labels Jan 28, 2026
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl Bot commented Jan 28, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl Bot commented Jan 28, 2026

❌ PR #161911 does not comply with backport policy

Confidence: medium
Explanation: This PR is aimed at preventing a nil pointer crash by adding a nil check in the pkg/sql/event_log.go file. According to the CockroachDB Backport Policy, the PR must address a critical bug or be gated behind a feature flag that is disabled by default. While preventing a nil pointer error can be categorized as addressing a stability issue (a critical bug), there is no clear evidence or confirmation that the issue meets the outlined 'critical bug' criteria such as causing data corruption, significant performance regression, or suboptimal performance. Moreover, there is no feature flag associated with this change.
Recommendation: Reconsider the backport or provide more evidence that the bug should be considered critical enough to warrant a backport without the need for a feature flag.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@github-actions
Copy link
Copy Markdown
Contributor

Reminder: it has been 2 weeks please merge or close your backport!

Copy link
Copy Markdown
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuzefovich reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball).

@mw5h
Copy link
Copy Markdown
Contributor

mw5h commented Feb 13, 2026

This is fine to backport, but you need a release justification.

@yuzefovich yuzefovich merged commit e5e1ca1 into release-25.4 Feb 14, 2026
18 of 19 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-25.4-161908 branch February 14, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-queries SQL Queries Team v25.4.6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants