Skip to content

CFE-3861: display index in cfbs status #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olehermanse merged 1 commit into from
Jun 3, 2025
Merged

CFE-3861: display index in cfbs status #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cfbs/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,13 @@ def status_command() -> int:
print("Name: %s" % config["name"])
print("Description: %s" % config["description"])
print("File: %s" % cfbs_filename())
if "index" in config:
Copy link
Contributor

@larsewi larsewi Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If index is not specified, then maybe the default index should be printed or literally the string Default index?

Copy link
Contributor Author

@jakub-nt jakub-nt Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket comment told to only display it when specified. I tend to agree though, I think it would be good to print something like Index: default.

Copy link
Contributor

@larsewi larsewi Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is fine by me ;)

index = config.raw_data["index"]

if type(index) is str:
print("Index: %s" % index)
else:
print("Index: %s" % "inline index in cfbs.json")
Copy link
Contributor

@larsewi larsewi Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print("Index: %s" % "inline index in cfbs.json")
print("Index: inline index in cfbs.json")


modules = config.get("build")
if not modules:
Expand Down