CFE-3861: display index in cfbs status
#225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
larsewi
approved these changes
Jun 2, 2025
| print("Name: %s" % config["name"]) | ||
| print("Description: %s" % config["description"]) | ||
| print("File: %s" % cfbs_filename()) | ||
| if "index" in config: |
Contributor
There was a problem hiding this comment.
If index is not specified, then maybe the default index should be printed or literally the string Default index?
Contributor
Author
There was a problem hiding this comment.
Ticket comment told to only display it when specified. I tend to agree though, I think it would be good to print something like Index: default.
Contributor
There was a problem hiding this comment.
Either way is fine by me ;)
| if type(index) is str: | ||
| print("Index: %s" % index) | ||
| else: | ||
| print("Index: %s" % "inline index in cfbs.json") |
Contributor
There was a problem hiding this comment.
Suggested change
| print("Index: %s" % "inline index in cfbs.json") | |
| print("Index: inline index in cfbs.json") |
olehermanse
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.